Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: xfa/fxfa/parser/xfa_object.h

Issue 2101403002: Pass element hash and name into CXFA_Object constructor. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@classname_return
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxfa/parser/xfa_object.h
diff --git a/xfa/fxfa/parser/xfa_object.h b/xfa/fxfa/parser/xfa_object.h
index a838b175787661548b1933076f1707013f4bb720..158650b2f3c743aef91901826a7a7666359da119 100644
--- a/xfa/fxfa/parser/xfa_object.h
+++ b/xfa/fxfa/parser/xfa_object.h
@@ -48,7 +48,9 @@ class CXFA_Object : public CFXJSE_HostObject {
public:
CXFA_Object(CXFA_Document* pDocument,
XFA_ObjectType objectType,
- XFA_Element eType);
+ XFA_Element eType,
+ uint32_t elementNameHash,
+ const CFX_WideStringC& elementName);
~CXFA_Object() override;
CXFA_Document* GetDocument() const { return m_pDocument; }
@@ -84,7 +86,7 @@ class CXFA_Object : public CFXJSE_HostObject {
const CXFA_NodeList* AsNodeList() const;
XFA_Element GetElementType() const;
- CFX_WideStringC GetClassName() const;
+ const CFX_WideStringC GetClassName() const;
Lei Zhang 2016/06/28 15:12:03 Is the const useful?
dsinclair 2016/06/28 15:42:09 Probably not, removed.
uint32_t GetClassHashCode() const;
void Script_ObjectClass_ClassName(CFXJSE_Value* pValue,
FX_BOOL bSetting,
@@ -95,6 +97,9 @@ class CXFA_Object : public CFXJSE_HostObject {
CXFA_Document* const m_pDocument;
const XFA_ObjectType m_objectType;
const XFA_Element m_elementType;
+
+ const uint32_t m_elementNameHash;
+ const CFX_WideStringC m_elementName;
};
using CXFA_ObjArray = CFX_ArrayTemplate<CXFA_Object*>;
@@ -619,7 +624,9 @@ class CXFA_Node : public CXFA_Object {
CXFA_Node(CXFA_Document* pDoc,
uint16_t ePacket,
XFA_ObjectType oType,
- XFA_Element eType);
+ XFA_Element eType,
+ uint32_t elementNameHash,
+ const CFX_WideStringC& elementName);
~CXFA_Node() override;
bool HasFlag(XFA_NodeFlag dwFlag) const;

Powered by Google App Engine
This is Rietveld 408576698