src/x64/deoptimizer-x64.cc - Issue 21014003: Optionally use 31-bits SMI value for 64-bit system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/deoptimizer-x64.cc

Issue 21014003: Optionally use 31-bits SMI value for 64-bit system (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed danno's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/deoptimizer-x64.cc

diff --git a/src/x64/deoptimizer-x64.cc b/src/x64/deoptimizer-x64.cc

index b45e9663e2a10c074178e0802aca949c3164f207..bf1e7bd82f47ed57f22c8f4a3a2806bb377095ae 100644

--- a/src/x64/deoptimizer-x64.cc

+++ b/src/x64/deoptimizer-x64.cc

@@ -83,7 +83,13 @@ void Deoptimizer::PatchCodeForDeoptimization(Isolate* isolate, Code* code) {

static const byte kJnsInstruction = 0x79;

+#if V8_USE_31_BIT_SMI_VALUE

+// The Smi::FromInt(reset_value) could be embedded as 4-byte in the generated

+// instruction stream from FullCodeGenerator::EmitProfilingCounterReset.

+static const byte kJnsOffset = 0x19;

+#else

static const byte kJnsOffset = 0x1d;

+#endif

static const byte kCallInstruction = 0xe8;

static const byte kNopByteOne = 0x66;

static const byte kNopByteTwo = 0x90;