src/x64/stub-cache-x64.cc - Issue 21014003: Optionally use 31-bits SMI value for 64-bit system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 21014003: Optionally use 31-bits SMI value for 64-bit system (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use (kSmiValueSize == 31) or (kSmiValueSize == 32) for SMI functions in macro assembler" Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 542018fddd084c20fb9fc1f024a4d8a92e41cccd..6e29ab412e45a7fc0ce4582c7cb64c7bbc787223 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -3056,6 +3056,7 @@ static void GenerateSmiKeyCheck(MacroAssembler* masm,

__ ucomisd(xmm_scratch1, xmm_scratch0);

__ j(not_equal, fail);

__ j(parity_even, fail); // NaN.

+ __ JumpIfNotValidSmiValue(scratch, fail);

__ Integer32ToSmi(key, scratch);

__ bind(&key_ok);

}