Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/x64/lithium-x64.cc

Issue 21014003: Optionally use 31-bits SMI value for 64-bit system (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/lithium-x64.cc
diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc
index 642cb272cf5fa1e2a8281ead6885ba7754fe07ad..208ab7d3b2bab0a1fc285d254454fc2950ba1c71 100644
--- a/src/x64/lithium-x64.cc
+++ b/src/x64/lithium-x64.cc
@@ -1884,7 +1884,12 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) {
} else if (val->HasRange() && val->range()->IsInSmiRange()) {
return DefineSameAsFirst(new(zone()) LSmiTag(value));
} else {
+#if !V8_USE_31_BITS_SMI_VALUE
LNumberTagI* result = new(zone()) LNumberTagI(value);
+#else
+ LOperand* temp = FixedTemp(xmm1);
+ LNumberTagI* result = new(zone()) LNumberTagI(value, temp);
+#endif
return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
}
} else if (to.IsSmi()) {
@@ -2118,9 +2123,20 @@ LInstruction* LChunkBuilder::DoLoadExternalArrayPointer(
LInstruction* LChunkBuilder::DoLoadKeyed(HLoadKeyed* instr) {
+#if !V8_USE_31_BITS_SMI_VALUE
ASSERT(instr->key()->representation().IsInteger32());
+#else
+ ASSERT(instr->key()->representation().IsSmiOrInteger32());
+#endif
ElementsKind elements_kind = instr->elements_kind();
+#if !V8_USE_31_BITS_SMI_VALUE
LOperand* key = UseRegisterOrConstantAtStart(instr->key());
+#else
+ bool clobbers_key = instr->key()->representation().IsSmi();
+ LOperand* key = clobbers_key
+ ? UseTempRegister(instr->key())
+ : UseRegisterOrConstantAtStart(instr->key());
+#endif
LLoadKeyed* result = NULL;
if (!instr->is_external()) {
@@ -2158,6 +2174,9 @@ LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
ElementsKind elements_kind = instr->elements_kind();
+#if V8_USE_31_BITS_SMI_VALUE
+ bool clobbers_key = instr->key()->representation().IsSmi();
+#endif
if (!instr->is_external()) {
ASSERT(instr->elements()->representation().IsTagged());
@@ -2169,7 +2188,12 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
if (instr->value()->representation().IsDouble()) {
object = UseRegisterAtStart(instr->elements());
val = UseTempRegister(instr->value());
+#if !V8_USE_31_BITS_SMI_VALUE
key = UseRegisterOrConstantAtStart(instr->key());
+#else
+ key = clobbers_key ? UseTempRegister(instr->key())
+ : UseRegisterOrConstantAtStart(instr->key());
+#endif
} else {
ASSERT(instr->value()->representation().IsSmiOrTagged());
object = UseTempRegister(instr->elements());
@@ -2178,7 +2202,12 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
key = UseTempRegister(instr->key());
} else {
val = UseRegisterOrConstantAtStart(instr->value());
+#if !V8_USE_31_BITS_SMI_VALUE
key = UseRegisterOrConstantAtStart(instr->key());
+#else
+ key = clobbers_key ? UseTempRegister(instr->key())
+ : UseRegisterOrConstantAtStart(instr->key());
+#endif
}
}
@@ -2198,7 +2227,12 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
elements_kind == EXTERNAL_FLOAT_ELEMENTS;
LOperand* val = val_is_temp_register ? UseTempRegister(instr->value())
: UseRegister(instr->value());
+#if !V8_USE_31_BITS_SMI_VALUE
LOperand* key = UseRegisterOrConstantAtStart(instr->key());
+#else
+ LOperand* key = clobbers_key ? UseTempRegister(instr->key())
+ : UseRegisterOrConstantAtStart(instr->key());
+#endif
LOperand* external_pointer = UseRegister(instr->elements());
return new(zone()) LStoreKeyed(external_pointer, key, val);
}

Powered by Google App Engine
This is Rietveld 408576698