Optionally use 31-bits SMI value for 64-bit system

src/x64/assembler-x64.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 360 matching lines @@
   };
 }
 
 
 // -----------------------------------------------------------------------------
 // Machine instruction Immediates
 
 class Immediate BASE_EMBEDDED {
  public:
   explicit Immediate(int32_t value) : value_(value) {}
+#if V8_USE_31_BITS_SMI_VALUE
+  explicit Immediate(Smi* value) {

[danno, 2013/07/29 13:02:23]

Don't add a Smi* constructor here. The wrapper function that allows inlining of
31-bit smis should do the work that this constructor does and call through to
the existing version.

[haitao.feng, 2013/07/30 08:56:43]

Done.

+    value_ = static_cast<int32_t>(reinterpret_cast<intptr_t>(value));
+  }
+#endif
 
  private:
   int32_t value_;
 
   friend class Assembler;
 };
 
 
 // -----------------------------------------------------------------------------
 // Machine instruction Operands
@@ skipping 590 matching lines @@
 
 
   void rcl(Register dst, Immediate imm8) {
     shift(dst, imm8, 0x2);
   }
 
   void rol(Register dst, Immediate imm8) {
     shift(dst, imm8, 0x0);
   }
 
+#if V8_USE_31_BITS_SMI_VALUE

[danno, 2013/07/29 13:02:23]

Is there some way to not including this conditionally? I think the assembler
should have no conditionally included code, it should be as "dumb" as possible
and not know anything about Smis if possible. 

[haitao.feng, 2013/07/30 08:56:43]

Done.

+  void roll(Register dst, Immediate imm8) {
+    shift_32(dst, imm8, 0x0);
+  }
+#endif
+
   void rcr(Register dst, Immediate imm8) {
     shift(dst, imm8, 0x3);
   }
 
   void ror(Register dst, Immediate imm8) {
     shift(dst, imm8, 0x1);
   }
 
   void rorl(Register dst, Immediate imm8) {
     shift_32(dst, imm8, 0x1);
@@ skipping 370 matching lines @@
     kRoundToNearest = 0x0,
     kRoundDown      = 0x1,
     kRoundUp        = 0x2,
     kRoundToZero    = 0x3
   };
 
   void roundsd(XMMRegister dst, XMMRegister src, RoundingMode mode);
 
   void movmskpd(Register dst, XMMRegister src);
   void movmskps(Register dst, XMMRegister src);
+#if V8_USE_31_BITS_SMI_VALUE
+  void pcmpeqd(XMMRegister dst, XMMRegister src);

[danno, 2013/07/29 13:02:23]

Why can't this always be part of the code (no conditional include)?

[haitao.feng, 2013/07/30 08:56:43]

Done.

+#endif
 
   // The first argument is the reg field, the second argument is the r/m field.
   void emit_sse_operand(XMMRegister dst, XMMRegister src);
   void emit_sse_operand(XMMRegister reg, const Operand& adr);
   void emit_sse_operand(XMMRegister dst, Register src);
   void emit_sse_operand(Register dst, XMMRegister src);
 
   // Debugging
   void Print();
 
@@ skipping 261 matching lines @@
  private:
   Assembler* assembler_;
 #ifdef DEBUG
   int space_before_;
 #endif
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_X64_ASSEMBLER_X64_H_