Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2101393003: ui/gl: On a core profile use sized types for R32F and RG32F (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/gl: On a core profile use sized types for R32F and RG32F BUG=620914 BUG=598902 Committed: https://crrev.com/add903e53f376a09a3b92a4912eed69b92d389e0 Cr-Commit-Position: refs/heads/master@{#402721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Corentin Wallez
PTAL
4 years, 5 months ago (2016-06-28 21:33:26 UTC) #2
Zhenyao Mo
On 2016/06/28 21:33:26, Corentin Wallez wrote: > PTAL LGTM
4 years, 5 months ago (2016-06-28 21:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101393003/1
4 years, 5 months ago (2016-06-28 21:46:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/208908)
4 years, 5 months ago (2016-06-28 22:19:32 UTC) #7
Corentin Wallez
On 2016/06/28 at 22:19:32, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
4 years, 5 months ago (2016-06-28 22:22:25 UTC) #9
piman
lgtm
4 years, 5 months ago (2016-06-28 23:09:45 UTC) #10
Corentin Wallez
On 2016/06/28 at 23:09:45, piman wrote: > lgtm Only the windows failure looks like it ...
4 years, 5 months ago (2016-06-29 03:54:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101393003/1
4 years, 5 months ago (2016-06-29 03:54:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 04:42:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:43:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/add903e53f376a09a3b92a4912eed69b92d389e0
Cr-Commit-Position: refs/heads/master@{#402721}

Powered by Google App Engine
This is Rietveld 408576698