Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101383002: [heap] Reland uncommit unused large object page memory. (Closed)

Created:
4 years, 5 months ago by Hannes Payer (out of office)
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland uncommit unused large object page memory. BUG= Committed: https://crrev.com/dd0ee5fd11653ba41a292641ccd66ae7cc5a8398 Cr-Commit-Position: refs/heads/master@{#37341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -22 lines) Patch
M src/base/hashmap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/base/platform/platform.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +13 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 7 chunks +87 lines, -21 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-617882.js View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
lgtm
4 years, 5 months ago (2016-06-28 17:37:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101383002/1
4 years, 5 months ago (2016-06-28 17:37:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 17:40:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd0ee5fd11653ba41a292641ccd66ae7cc5a8398 Cr-Commit-Position: refs/heads/master@{#37341}
4 years, 5 months ago (2016-06-28 17:41:41 UTC) #7
Hannes Payer (out of office)
4 years, 5 months ago (2016-06-28 20:20:14 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2106933003/ by hpayer@chromium.org.

The reason for reverting is: Crashes unbox-double-arrays.

Powered by Google App Engine
This is Rietveld 408576698