Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2101323003: mash: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, sky, dcheng
CC:
chromium-reviews, kalyank, sadrul, Ben Goodger (Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=sky, danakj, dcheng BUG=554600 Committed: https://crrev.com/e8f87e7cc93e47aeea704006fe1ebdf273ddaba9 Cr-Commit-Position: refs/heads/master@{#402618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mash/browser/browser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:37:31 UTC) #1
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:08:21 UTC) #2
sky
LGTM
4 years, 5 months ago (2016-06-28 22:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101323003/1
4 years, 5 months ago (2016-06-28 22:34:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 00:40:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:42:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8f87e7cc93e47aeea704006fe1ebdf273ddaba9
Cr-Commit-Position: refs/heads/master@{#402618}

Powered by Google App Engine
This is Rietveld 408576698