Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2101323002: Add 'NavigationHandle::QueueConsoleMessage'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extensions_unittests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 54924a4ec63d1e616ce8f3c83a5b1847b2d0b92a..53b9d4ffe31461d0d7e2232290669bea885fc31e 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -9,6 +9,7 @@
#include "content/common/content_export.h"
#include "content/public/browser/navigation_throttle.h"
+#include "content/public/common/console_message_level.h"
#include "content/public/common/referrer.h"
#include "net/base/net_errors.h"
#include "ui/base/page_transition_types.h"
@@ -159,6 +160,13 @@ class CONTENT_EXPORT NavigationHandle {
virtual void CancelDeferredNavigation(
NavigationThrottle::ThrottleCheckResult result) = 0;
+ // Adds a console message to the NavigationHandle's message queue. Messages
+ // queued before the navigation is ready to commit will be delivered to the
+ // final RenderFrameHost upon commit. Messages queued after the navigation has
+ // committed will be delivered immediately.
+ virtual void QueueConsoleMessage(ConsoleMessageLevel level,
clamy 2016/06/28 11:30:38 The policy of content is not to add a method to th
Mike West 2016/06/28 12:22:33 You're right, sorry. I'd convinced myself that htt
+ const std::string& message) = 0;
+
// Testing methods ----------------------------------------------------------
//
// The following methods should be used exclusively for writing unit tests.

Powered by Google App Engine
This is Rietveld 408576698