media/audio/cras/cras_unified.h - Issue 2101303004: Pass delay and timestamp to AudioSourceCallback::OnMoreData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/cras/cras_unified.h

Issue 2101303004: Pass delay and timestamp to AudioSourceCallback::OnMoreData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Pass target playout time to AudioSourceCallback::OnMoreData. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/cras/cras_unified.h

diff --git a/media/audio/cras/cras_unified.h b/media/audio/cras/cras_unified.h

index 4b75802effe50f1994cf43fb6946f3678b55d3f6..0a6c9388e0124221f387286b3559f7a05ece3a45 100644

--- a/media/audio/cras/cras_unified.h

+++ b/media/audio/cras/cras_unified.h

@@ -18,6 +18,7 @@

#include "base/compiler_specific.h"

#include "base/macros.h"

+#include "base/time/time.h"

#include "media/audio/audio_io.h"

#include "media/base/audio_parameters.h"

@@ -50,7 +51,7 @@ class MEDIA_EXPORT CrasUnifiedStream : public AudioOutputStream {

private:

// Convert Latency in time to bytes.

- uint32_t GetBytesLatency(const struct timespec& latency);

+ base::TimeTicks GetTargetPlayoutTime(const struct timespec& latency_ts);

// Handles captured audio and fills the ouput with audio to be played.

static int UnifiedCallback(cras_client* client,

« media/audio/audio_output_resampler.cc ('K') | « media/audio/audio_output_stream_sink.cc ('k') | media/audio/cras/cras_unified.cc » ('j') | media/audio/fake_audio_input_stream.cc » ('J')