media/audio/alsa/alsa_output.h - Issue 2101303004: Pass delay and timestamp to AudioSourceCallback::OnMoreData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/alsa/alsa_output.h

Issue 2101303004: Pass delay and timestamp to AudioSourceCallback::OnMoreData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Pass target playout time to AudioSourceCallback::OnMoreData. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/capture/web_contents_audio_muter.cc ('K') | « content/browser/media/capture/web_contents_audio_muter.cc ('k') | media/audio/alsa/alsa_output.cc » ('j') | media/audio/alsa/alsa_output_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/alsa/alsa_output.h

diff --git a/media/audio/alsa/alsa_output.h b/media/audio/alsa/alsa_output.h

index 7b2337a3378230fda9ac169bc119ed458aa5a1ff..5b1880ef572a4cba4d5ecc272f17bb1b48597288 100644

--- a/media/audio/alsa/alsa_output.h

+++ b/media/audio/alsa/alsa_output.h

@@ -152,7 +152,7 @@ class MEDIA_EXPORT AlsaPcmOutputStream : public AudioOutputStream,

// is passed into the output stream, but ownership is not transfered which

// requires a synchronization on access of the |source_callback_| to avoid

// using a deleted callback.

- int RunDataCallback(AudioBus* audio_bus, uint32_t total_bytes_delay);

+ int RunDataCallback(base::TimeTicks target_playout_time, AudioBus* audio_bus);

void RunErrorCallback(int code);

// Changes the AudioSourceCallback to proxy calls to. Pass in NULL to