Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: media/audio/pulse/pulse_output.cc

Issue 2101303004: Pass delay and timestamp to AudioSourceCallback::OnMoreData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix Mac CQ errors. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/pulse/pulse_output.cc
diff --git a/media/audio/pulse/pulse_output.cc b/media/audio/pulse/pulse_output.cc
index 3aef9476720106208a92be3cab41ee5e4df0a81b..f6d115ebb806c6468dad36dc8369df3004066902 100644
--- a/media/audio/pulse/pulse_output.cc
+++ b/media/audio/pulse/pulse_output.cc
@@ -8,6 +8,7 @@
#include <stdint.h>
#include "base/single_thread_task_runner.h"
+#include "base/time/time.h"
#include "media/audio/audio_device_description.h"
#include "media/audio/audio_manager_base.h"
#include "media/audio/pulse/pulse_util.h"
@@ -132,10 +133,9 @@ void PulseAudioOutputStream::FulfillWriteRequest(size_t requested_bytes) {
int frames_filled = 0;
if (source_callback_) {
- const uint32_t hardware_delay = pulse::GetHardwareLatencyInBytes(
- pa_stream_, params_.sample_rate(), params_.GetBytesPerFrame());
- frames_filled =
- source_callback_->OnMoreData(audio_bus_.get(), hardware_delay, 0);
+ const base::TimeDelta delay = pulse::GetHardwareLatency(pa_stream_);
+ frames_filled = source_callback_->OnMoreData(
+ delay, base::TimeTicks::Now(), 0, audio_bus_.get());
// Zero any unfilled data so it plays back as silence.
if (frames_filled < audio_bus_->frames()) {

Powered by Google App Engine
This is Rietveld 408576698