Pass delay and timestamp to AudioSourceCallback::OnMoreData.

media/audio/mac/audio_auhal_mac.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_auhal_mac.h"
 
 #include <CoreServices/CoreServices.h>
 
+#include <algorithm>
+#include <string>
+
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/mac/mac_logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
-#include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "media/audio/mac/audio_manager_mac.h"
 #include "media/base/audio_pull_fifo.h"
 
+namespace {
+
+base::TimeDelta FramesToTimeDelta(int frames, int sample_rate) {
+  return base::TimeDelta::FromMicroseconds(
+      frames * base::Time::kMicrosecondsPerSecond / sample_rate);

[chcunningham, 2016/09/23 20:53:30]

integer division

[jameswest, 2016/09/29 00:52:24]

Removed.

+}
+
+}  // namespace
+
 namespace media {
 
 static void WrapBufferList(AudioBufferList* buffer_list,
                            AudioBus* bus,
                            int frames) {
   DCHECK(buffer_list);
   DCHECK(bus);
   const int channels = bus->channels();
   const int buffer_list_channels = buffer_list->mNumberBuffers;
   CHECK_EQ(channels, buffer_list_channels);
@@ skipping 14 matching lines @@
                          const AudioManager::LogCallback& log_callback)
     : manager_(manager),
       params_(params),
       output_channels_(params_.channels()),
       number_of_frames_(params_.frames_per_buffer()),
       number_of_frames_requested_(0),
       source_(NULL),
       device_(device),
       audio_unit_(0),
       volume_(1),
-      hardware_latency_frames_(0),
       stopped_(true),
-      current_hardware_pending_bytes_(0),
       current_lost_frames_(0),
       last_sample_time_(0.0),
       last_number_of_frames_(0),
       total_lost_frames_(0),
       largest_glitch_frames_(0),
       glitches_detected_(0),
       log_callback_(log_callback) {
   // We must have a manager.
   DCHECK(manager_);
   CHECK(!log_callback_.Equals(AudioManager::LogCallback()));
@@ skipping 43 matching lines @@
     return false;
   }
 
   // The output bus will wrap the AudioBufferList given to us in
   // the Render() callback.
   DCHECK_GT(output_channels_, 0);
   output_bus_ = AudioBus::CreateWrapper(output_channels_);
 
   bool configured = ConfigureAUHAL();
   if (configured)
-    hardware_latency_frames_ = GetHardwareLatency();
+    hardware_latency_ = GetHardwareLatency();
 
   return configured;
 }
 
 void AUHALStream::Close() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DVLOG(1) << "Close";
   CloseAudioUnit();
   // Inform the audio manager that we have been closed. This will cause our
   // destruction. Also include the device ID as a signal to the audio manager
@@ skipping 99 matching lines @@
       audio_fifo_.reset(new AudioPullFifo(
           output_channels_,
           number_of_frames_,
           base::Bind(&AUHALStream::ProvideInput, base::Unretained(this))));
     }
   }
 
   // Make |output_bus_| wrap the output AudioBufferList.
   WrapBufferList(data, output_bus_.get(), number_of_frames);
 
-  // Update the playout latency.
-  const double playout_latency_frames = GetPlayoutLatency(output_time_stamp);
-  current_hardware_pending_bytes_ = static_cast<uint32_t>(
-      (playout_latency_frames + 0.5) * params_.GetBytesPerFrame());
+  current_playout_time_ = GetPlayoutTime(output_time_stamp);
 
   if (audio_fifo_)
     audio_fifo_->Consume(output_bus_.get(), output_bus_->frames());
   else
     ProvideInput(0, output_bus_.get());
 
   last_number_of_frames_ = number_of_frames;
 
   return noErr;
 }
 
 void AUHALStream::ProvideInput(int frame_delay, AudioBus* dest) {
   base::AutoLock auto_lock(source_lock_);
   if (!source_) {
     dest->Zero();
     return;
   }
 
+  const base::TimeTicks playout_time =
+      current_playout_time_ +
+      FramesToTimeDelta(frame_delay, params_.sample_rate());
+  const base::TimeTicks now = base::TimeTicks::Now();
+  const base::TimeDelta delay = playout_time - now;
+
   // Supply the input data and render the output data.
-  source_->OnMoreData(dest, current_hardware_pending_bytes_ +
-                                frame_delay * params_.GetBytesPerFrame(),
-                      current_lost_frames_);
+  source_->OnMoreData(delay, now, current_lost_frames_, dest);
   dest->Scale(volume_);
   current_lost_frames_ = 0;
 }
 
 // AUHAL callback.
 OSStatus AUHALStream::InputProc(
     void* user_data,
     AudioUnitRenderActionFlags* flags,
     const AudioTimeStamp* output_time_stamp,
     UInt32 bus_number,
     UInt32 number_of_frames,
     AudioBufferList* io_data) {
   // Dispatch to our class method.
   AUHALStream* audio_output =
       static_cast<AUHALStream*>(user_data);
   if (!audio_output)
     return -1;
 
   return audio_output->Render(
       flags,
       output_time_stamp,
       bus_number,
       number_of_frames,
       io_data);
 }
 
-double AUHALStream::GetHardwareLatency() {
+base::TimeDelta AUHALStream::GetHardwareLatency() {
   if (!audio_unit_ || device_ == kAudioObjectUnknown) {
     DLOG(WARNING) << "AudioUnit is NULL or device ID is unknown";
-    return 0.0;
+    return base::TimeDelta();
   }
 
   // Get audio unit latency.
   Float64 audio_unit_latency_sec = 0.0;
   UInt32 size = sizeof(audio_unit_latency_sec);
   OSStatus result = AudioUnitGetProperty(
       audio_unit_,
       kAudioUnitProperty_Latency,
       kAudioUnitScope_Global,
       0,
       &audio_unit_latency_sec,
       &size);
   if (result != noErr) {
     OSSTATUS_DLOG(WARNING, result) << "Could not get AudioUnit latency";
-    return 0.0;
+    return base::TimeDelta();
   }
 
   // Get output audio device latency.
   static const AudioObjectPropertyAddress property_address = {
     kAudioDevicePropertyLatency,
     kAudioDevicePropertyScopeOutput,
     kAudioObjectPropertyElementMaster
   };
 
   UInt32 device_latency_frames = 0;
   size = sizeof(device_latency_frames);
   result = AudioObjectGetPropertyData(
       device_,
       &property_address,
       0,
       NULL,
       &size,
       &device_latency_frames);
   if (result != noErr) {
     OSSTATUS_DLOG(WARNING, result) << "Could not get audio device latency";
-    return 0.0;
+    return base::TimeDelta();
   }
 
-  return static_cast<double>((audio_unit_latency_sec *
-      output_format_.mSampleRate) + device_latency_frames);
+  int latency_frames = audio_unit_latency_sec * output_format_.mSampleRate +
+                       device_latency_frames;
+
+  return FramesToTimeDelta(latency_frames, params_.sample_rate());
 }
 
-double AUHALStream::GetPlayoutLatency(
+base::TimeTicks AUHALStream::GetPlayoutTime(
     const AudioTimeStamp* output_time_stamp) {
-  // Ensure mHostTime is valid.
+  // A platform bug has been observed where the platform sometimes reports that
+  // the next frames will be output at an invalid time or a time in the past.
+  // Because the target playout time cannot be invalid or in the past, return
+  // "now" in these cases.
   if ((output_time_stamp->mFlags & kAudioTimeStampHostTimeValid) == 0)
-    return 0;
+    return base::TimeTicks::Now();
 
-  // Get the delay between the moment getting the callback and the scheduled
-  // time stamp that tells when the data is going to be played out.
-  UInt64 output_time_ns = AudioConvertHostTimeToNanos(
-      output_time_stamp->mHostTime);
-  UInt64 now_ns = AudioConvertHostTimeToNanos(AudioGetCurrentHostTime());
-
-  // Prevent overflow leading to huge delay information; occurs regularly on
-  // the bots, probably less so in the wild.
-  if (now_ns > output_time_ns)
-    return 0;
-
-  double delay_frames = static_cast<double>
-      (1e-9 * (output_time_ns - now_ns) * output_format_.mSampleRate);
-
-  return (delay_frames + hardware_latency_frames_);
+  return std::max(base::TimeTicks::FromMachAbsoluteTime(
+                      output_time_stamp->mHostTime),
+                  base::TimeTicks::Now()) +
+         hardware_latency_;
 }
 
 void AUHALStream::UpdatePlayoutTimestamp(const AudioTimeStamp* timestamp) {
   if ((timestamp->mFlags & kAudioTimeStampSampleTimeValid) == 0)
     return;
 
   if (last_sample_time_) {
     DCHECK_NE(0U, last_number_of_frames_);
     UInt32 diff =
         static_cast<UInt32>(timestamp->mSampleTime - last_sample_time_);
@@ skipping 187 matching lines @@
   OSStatus result = AudioUnitUninitialize(audio_unit_);
   OSSTATUS_DLOG_IF(ERROR, result != noErr, result)
       << "AudioUnitUninitialize() failed.";
   result = AudioComponentInstanceDispose(audio_unit_);
   OSSTATUS_DLOG_IF(ERROR, result != noErr, result)
       << "AudioComponentInstanceDispose() failed.";
   audio_unit_ = 0;
 }
 
 }  // namespace media