Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 21013004: Remove support for getters with parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/deprecated_features_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 607bc6e9d35a50fe61c2b1c3b3d1ca290bd42a11..1dfc84ca20c5d4395e9c320c1234379751f700a9 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -1515,7 +1515,7 @@ class TypeResolver {
visitor, node, typdef.typeVariables, arguments);
if (hasTypeArgumentMismatch) {
type = new BadTypedefType(typdef,
- new TypedefType.forUserProvidedBadType(typdef,
+ new TypedefType.forUserProvidedBadType(typdef,
arguments.toLink()));
} else {
if (arguments.isEmpty) {
@@ -3854,14 +3854,8 @@ class SignatureResolver extends CommonResolverVisitor<Element> {
if (!identical(formalParameters.getEndToken().next.stringValue,
// TODO(ahe): Remove the check for native keyword.
'native')) {
- if (compiler.rejectDeprecatedFeatures &&
- // TODO(ahe): Remove isPlatformLibrary check.
- !element.getLibrary().isPlatformLibrary) {
- compiler.reportError(formalParameters,
- MessageKind.EXTRA_FORMALS);
- } else {
- compiler.onDeprecatedFeature(formalParameters, 'getter parameters');
- }
+ compiler.reportError(formalParameters,
+ MessageKind.EXTRA_FORMALS);
}
}
LinkBuilder<Element> parametersBuilder =
@@ -3890,10 +3884,6 @@ class SignatureResolver extends CommonResolverVisitor<Element> {
MessageKind.ILLEGAL_SETTER_FORMALS);
}
}
- if (element.isGetter() && (requiredParameterCount != 0
- || visitor.optionalParameterCount != 0)) {
- compiler.reportError(formalParameters, MessageKind.EXTRA_FORMALS);
- }
return new FunctionSignatureX(parameters,
visitor.optionalParameters,
requiredParameterCount,
« no previous file with comments | « no previous file | tests/compiler/dart2js/deprecated_features_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698