Issue 21013003: Added unit tests for the slightly confusing Boolean/BooleanObject API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21013003: Added unit tests for the slightly confusing Boolean/BooleanObject API. (Closed)

Created:
7 years, 4 months ago by Sven Panne

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Added unit tests for the slightly confusing Boolean/BooleanObject API. Just for documenting the status quo. As discussed offline, we should probably rename/deprecate a few things: NumberObject::NumberValue() => NumberObject::ValueOf() BooleanObject::BooleanValue() => BooleanObject::ValueOf() StringObject::StringValue => StringObject::ValueOf() R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15935

Patch Set 1 #

Patch Set 2 : Fixed copy-n-paste typo #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	M	test/cctest/test-api.cc	View	1	2 chunks	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. And as discussed offline, +1 on the renaming and the new "ValueOf" name, but ...

7 years, 4 months ago (2013-07-29 12:36:40 UTC) #2

Sven Panne

7 years, 4 months ago (2013-07-29 12:38:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15935 (presubmit successful).

Expand Messages | Collapse Messages