Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2101293003: Clarify that SiteInstance::GetSiteURL is usually not accurate. (Closed)

Created:
4 years, 5 months ago by Charlie Reis
Modified:
4 years, 5 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, Jialiu Lin, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify that SiteInstance::GetSiteURL is usually not accurate. It is only useful for sites that require dedicated processes, or in --site-per-process mode. BUG=none TEST=No behavior change. Committed: https://crrev.com/11291923d4c938142d6fdd6653a33e2df8a2b06e Cr-Commit-Position: refs/heads/master@{#402633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/public/browser/site_instance.h View 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Reis
Nasko, can you review this documentation update? Jialiu reminded me that we don't have any ...
4 years, 5 months ago (2016-06-28 23:16:09 UTC) #2
nasko
This has been long overdue, so thanks for clarifying it! LGTM
4 years, 5 months ago (2016-06-28 23:34:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101293003/1
4 years, 5 months ago (2016-06-28 23:38:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 01:45:26 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:48:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11291923d4c938142d6fdd6653a33e2df8a2b06e
Cr-Commit-Position: refs/heads/master@{#402633}

Powered by Google App Engine
This is Rietveld 408576698