Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2101283002: Add crash keys to LocalDOMWindow to help diagnose bug 621730. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index f6573e38431fe5c1f24825e2a4c473edb2563d4e..e9375a1c6b5eb725027b5fb3c177a258dc80d168 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -79,6 +79,7 @@
#include "public/platform/Platform.h"
#include "public/platform/WebFrameScheduler.h"
#include "public/platform/WebScreenInfo.h"
+#include "wtf/debug/CrashLogging.h"
#include <memory>
namespace blink {
@@ -687,6 +688,12 @@ void LocalDOMWindow::postMessageTimerFired(PostMessageTimer* timer)
UserGestureIndicator gestureIndicator(timer->userGestureToken());
event->entangleMessagePorts(document());
+
+ // Temporary instrumentation for http://crbug.com/621730.
+ WTF::debug::ScopedCrashKey("postmessage_src_origin", event->origin().utf8().data());
+ WTF::debug::ScopedCrashKey("postmessage_dst_origin", document()->getSecurityOrigin()->toRawString().utf8().data());
+ WTF::debug::ScopedCrashKey("postmessage_dst_url", document()->url().getString().utf8().data());
+
dispatchMessageEventWithOriginCheck(timer->targetOrigin(), event, timer->takeLocation());
}
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698