mash: Migrate AccessibilityDelegate access to WmShell.

mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org

Committed: https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4
Cr-Commit-Position: refs/heads/master@{#402645}

[msw, 2016-06-28 22:17:56]

Hey James, please take a look; thanks!

[msw, 2016-06-28 22:18:03]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 22:18:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-06-28 22:34:25]

LGTM

https://codereview.chromium.org/2101263004/diff/20001/ash/accelerators/spoken...
File ash/accelerators/spoken_feedback_toggler_unittest.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/accelerators/spoken...
ash/accelerators/spoken_feedback_toggler_unittest.cc:16: typedef
test::AshTestBase SpokenFeedbackTogglerTest;
optional nit: using

https://codereview.chromium.org/2101263004/diff/20001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:118: if (!pass_through_surface &&
spoken_feedback_enabled &&
Thanks for the rename - it's clearer.

https://codereview.chromium.org/2101263004/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (left):

https://codereview.chromium.org/2101263004/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.cc:26: #include "ash/shell.h"
Hooray!

https://codereview.chromium.org/2101263004/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector_unittest.cc:107: public
testing::WithParamInterface<MaterialDesignController::Mode> {
I would leave the MaterialDesignController ones. The MD guys have both a
ui::MaterialDesignController and an ash::MaterialDesignController (ugh) and have
been trying to explicitly include namespace specifiers to make it easier for
them to read the code. I don't feel strongly, so I've been letting them do it.

https://codereview.chromium.org/2101263004/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
(right):

https://codereview.chromium.org/2101263004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc:29:
namespace ui {
optional: kinda weird that this file is in namespace ui

[msw, 2016-06-28 22:49:07]

Description was changed from

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org
==========

[msw, 2016-06-28 22:49:08]

msw@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[msw, 2016-06-28 22:49:50]

+TBR dmazzoni for touch_exploration_controller_browsertest.cc

https://codereview.chromium.org/2101263004/diff/20001/ash/accelerators/spoken...
File ash/accelerators/spoken_feedback_toggler_unittest.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/accelerators/spoken...
ash/accelerators/spoken_feedback_toggler_unittest.cc:16: typedef
test::AshTestBase SpokenFeedbackTogglerTest;
On 2016/06/28 22:34:25, James Cook wrote:
> optional nit: using

Done.

https://codereview.chromium.org/2101263004/diff/20001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:118: if (!pass_through_surface &&
spoken_feedback_enabled &&
On 2016/06/28 22:34:25, James Cook wrote:
> Thanks for the rename - it's clearer.

Acknowledged.

https://codereview.chromium.org/2101263004/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (left):

https://codereview.chromium.org/2101263004/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.cc:26: #include "ash/shell.h"
On 2016/06/28 22:34:25, James Cook wrote:
> Hooray!

Acknowledged.

https://codereview.chromium.org/2101263004/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_unittest.cc (right):

https://codereview.chromium.org/2101263004/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector_unittest.cc:107: public
testing::WithParamInterface<MaterialDesignController::Mode> {
On 2016/06/28 22:34:25, James Cook wrote:
> I would leave the MaterialDesignController ones. The MD guys have both a
> ui::MaterialDesignController and an ash::MaterialDesignController (ugh) and
have
> been trying to explicitly include namespace specifiers to make it easier for
> them to read the code. I don't feel strongly, so I've been letting them do it.

Done.

https://codereview.chromium.org/2101263004/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
(right):

https://codereview.chromium.org/2101263004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc:29:
namespace ui {
On 2016/06/28 22:34:25, James Cook wrote:
> optional: kinda weird that this file is in namespace ui

Done.

[msw, 2016-06-28 22:49:59]

The CQ bit was checked by msw@chromium.org

[msw, 2016-06-28 22:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2101263004/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-06-28 22:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:55:01]

Description was changed from

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org
==========

to

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 01:55:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 01:56:24]

Description was changed from

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org
==========

to

==========
mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org

Committed: https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4
Cr-Commit-Position: refs/heads/master@{#402645}
==========

[commit-bot: I haz the power, 2016-06-29 01:56:25]

Patchset 3 (id:??) landed as
https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4
Cr-Commit-Position: refs/heads/master@{#402645}