[MD settings] certificate manager closure compilation

chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A dialog for showing SSL certificate related error messages.
  * The user can only close the dialog, there is no other possible interaction.
  */
 Polymer({
   is: 'settings-certificates-error-dialog',
 
   properties: {
     /** @type {!CertificatesError|!CertificatesImportError} */
     model: Object,
   },
 
   /** @override */
   attached: function() {
     this.$.dialog.open();

[dpapad, 2016/06/29 22:28:41]

I am surprised that this compiles. How does the compiler what is the type of
this.$.dialog? Even if it does somehow, cr-dialog is not in the deps list.

[dschuyler, 2016/06/30 17:13:32]

IIUC, the $.foo get's translated to $['foo'] prior to the compile. That may
affect how the code is checked.

[dpapad, 2016/06/30 17:51:22]

cr-dialog has now a compile target, see
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog....
Can we cast this to CrDialogElement so that we have type coverage here. IIUC
currently the compiler skips type-checking because it does not know the type.

[dschuyler, 2016/06/30 20:52:14]

That's possible. Let's do that in a separate CL.

   },
 
   /** @private */
   onOkTap_: function() {
     this.$.dialog.close();
   },
 
   /**
-   * @param {{certificateName: string, error: string}} importError
+   * @param {{name: string, error: string}} importError
    * @return {string}
    * @private
    */
   getCertificateErrorText_: function(importError) {
     return loadTimeData.getStringF(
         'certificateImportErrorFormat', importError.name, importError.error);
   },
 });