[MD settings] certificate manager closure compilation

chrome/browser/resources/settings/certificate_manager_page/certificates_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Manage certificates" section
  * to interact with the browser.
  */
 
 /**
  * @typedef {{
- *   extractable: boolean,
- *   id: string,
- *   name: string,
- *   policy: boolean,
- *   readonly: boolean,
- *   untrusted: boolean,
- * }}
- * @see chrome/browser/ui/webui/settings/certificates_handler.cc
- */
-var CertificateSubnode;
-
-/**
- * A data structure describing a certificate that is currently being imported,
- * therefore it has no ID yet, but it has a name. Used within JS only.
- * @typedef {{
- *   name: string,
- * }}
- */
-var NewCertificateSubNode;
-
-/**
- * @typedef {{
  *   id: string,
  *   name: string,
  *   subnodes: !Array<!CertificateSubnode>
  * }}
  * @see chrome/browser/ui/webui/settings/certificates_handler.cc
  */
 var Certificate;

[dpapad, 2016/06/29 22:28:41]

Some of the typedefs are moved to the new file and some stayed here. Is there a
rule about which should go in the new file?

[dschuyler, 2016/06/30 17:13:32]

It was only done as needed to compile. I've moved some of the 
types back into the proxy after changing the dependency between
the proxy and the types file.

 
 /**
  * @typedef {{
  *   ssl: boolean,
  *   email: boolean,
  *   objSign: boolean
  * }}
  */
 var CaTrustInfo;
 
 /**
  * Generic error returned from C++ via a Promise reject callback.
  * @typedef {{
  *   title: string,
  *   description: string
  * }}
  * @see chrome/browser/ui/webui/settings/certificates_handler.cc
  */
 var CertificatesError;
 
 
 /**
  * Error returned from C++ via a Promise reject callback, when some certificates
  * fail to be imported.
  * @typedef {{
  *   title: string,
- *   description: string
+ *   description: string,
  *   certificateErrors: !Array<{name: string, error: string}>
  * }}
  * @see chrome/browser/ui/webui/settings/certificates_handler.cc
  */
 var CertificatesImportError;
 
 cr.define('settings', function() {
-  /**
-   * Enumeration of all possible certificate types.
-   * @enum {string}
-   */
-  var CertificateType = {
-    CA: 'ca',
-    OTHER: 'other',
-    PERSONAL: 'personal',
-    SERVER: 'server',
-  };
 
   /** @interface */
   function CertificatesBrowserProxy() {}
 
   CertificatesBrowserProxy.prototype = {
     /**
      * Triggers 5 events in the following order
      * 1x 'certificates-model-ready' event.
      * 4x 'certificates-changed' event, one for each certificate category.
      */
@@ skipping 167 matching lines @@
       return cr.sendWithPromise('importCaCertificate');
     },
 
     /** @override */
     importServerCertificate: function() {
       return cr.sendWithPromise('importServerCertificate');
     },
   };
 
   return {
+    CertificatesBrowserProxy: CertificatesBrowserProxy,
     CertificatesBrowserProxyImpl: CertificatesBrowserProxyImpl,
-    CertificateType: CertificateType,
   };
 });