maxspanlength setter

tool/input_sdk/private/debugger.dart

Index: tool/input_sdk/private/debugger.dart
diff --git a/tool/input_sdk/private/debugger.dart b/tool/input_sdk/private/debugger.dart
index 85c296503ca2532d8f92e524d8ba48e45a802309..85f5dcc579f04c8884a37ecd5f36f2edc362db44 100644
--- a/tool/input_sdk/private/debugger.dart
+++ b/tool/input_sdk/private/debugger.dart
@@ -30,7 +30,7 @@ class JsonMLConfig {
   static const keyToString = const JsonMLConfig("keyToString");
 }
 
-int maxSpanLength = 100;
+int _maxSpanLength = 100;
 
 var _devtoolsFormatter = new JsonMLFormatter(new DartFormatter());
 
@@ -220,6 +220,8 @@ class JsonMLFormatter {
 
   JsonMLFormatter(this._simpleFormatter);
 
+  set maxSpanLength(int spanLength) => _maxSpanLength = spanLength;

[Jacob, 2016/06/28 18:59:11]

why is this needed?
Having a public field should have the same externally visible effect.

[bmilligan, 2016/06/28 20:12:31]

I don't have access to the debugger.dart file, but only the JsonMLFormatter.
Setting devtoolsFormatters[0].maxSpanLength = 6 for example doesn't result in
any change. If I add this setter, though, that command works. Is there a
different way to access the public variable without the setter?

[Jacob, 2016/06/28 20:36:37]

Oh clever. I like this hack. I missed this was inside the JsonMLFormatter class
before.
Just add a comment explaining what you described in your comment so it is clear
that this method was added purely for testing purposes.
Otherwise it would seem to be a bug that you have a instance setters that sets
the value of a top level field.
Another option is to make the property name intentionally ugly so it is really
clear what is going on. E.g.

void setMaxSpanLengthForTestingOnly(int spanLength) => _maxSpanLength =
spanLength;

[bmilligan, 2016/06/28 20:45:08]

Done.

+
   header(object, config) {
     if (config == JsonMLConfig.skipDart || isNativeJavaScriptObject(object)) {
       return null;
@@ -633,7 +635,7 @@ class IterableSpanFormatter implements Formatter {
 List<NameValuePair> childrenHelper(IterableSpan span) {
   var length = span.end - span.start;
   var ret = new List<NameValuePair>();
-  if (length <= maxSpanLength) {
+  if (length <= _maxSpanLength) {
     for (var i = span.start; i < span.end; i++) {
       /// TODO(bmilligan): Stop using elementAt if it becomes a performance
       /// bottleneck in the future.
@@ -647,8 +649,8 @@ List<NameValuePair> childrenHelper(IterableSpan span) {
     /// maxPowerOfSubsetSize of 2, so the list will be broken up into 1
     /// 10000-length subset and 1 1-length subset.
     var maxPowerOfSubsetSize =
-        (log(length - .5) / log(maxSpanLength)).truncate();
-    var subsetSize = pow(maxSpanLength, maxPowerOfSubsetSize);
+        (log(length - .5) / log(_maxSpanLength)).truncate();
+    var subsetSize = pow(_maxSpanLength, maxPowerOfSubsetSize);
     for (var i = span.start; i < span.end; i += subsetSize) {
       var endIndex = min(span.end, subsetSize + i);
       if (endIndex - i == 1)