maxspanlength setter

maxspanlength setter


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


comments and 10001 case


naming and logic changes


logic updates and variable renaming


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Array formatting customized to look like JS

BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/c4e30ddb1d4fe8399ce0dc50c8768b6a1e659a15

[bmilligan, 2016-06-28 18:38:41]

bmilligan@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2016-06-28 18:59:11]

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:223: set maxSpanLength(int spanLength) =>
_maxSpanLength = spanLength;
why is this needed?
Having a public field should have the same externally visible effect.

[bmilligan, 2016-06-28 20:12:31]

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:223: set maxSpanLength(int spanLength) =>
_maxSpanLength = spanLength;
On 2016/06/28 18:59:11, Jacob wrote:
> why is this needed?
> Having a public field should have the same externally visible effect.

I don't have access to the debugger.dart file, but only the JsonMLFormatter.
Setting devtoolsFormatters[0].maxSpanLength = 6 for example doesn't result in
any change. If I add this setter, though, that command works. Is there a
different way to access the public variable without the setter?

[Jacob, 2016-06-28 20:36:38]

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:223: set maxSpanLength(int spanLength) =>
_maxSpanLength = spanLength;
On 2016/06/28 20:12:31, bmilligan wrote:
> On 2016/06/28 18:59:11, Jacob wrote:
> > why is this needed?
> > Having a public field should have the same externally visible effect.
> 
> I don't have access to the debugger.dart file, but only the JsonMLFormatter.
> Setting devtoolsFormatters[0].maxSpanLength = 6 for example doesn't result in
> any change. If I add this setter, though, that command works. Is there a
> different way to access the public variable without the setter?
Oh clever. I like this hack. I missed this was inside the JsonMLFormatter class
before.
Just add a comment explaining what you described in your comment so it is clear
that this method was added purely for testing purposes.
Otherwise it would seem to be a bug that you have a instance setters that sets
the value of a top level field.
Another option is to make the property name intentionally ugly so it is really
clear what is going on. E.g.

void setMaxSpanLengthForTestingOnly(int spanLength) => _maxSpanLength =
spanLength;

[bmilligan, 2016-06-28 20:45:08]

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2101233004/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:223: set maxSpanLength(int spanLength) =>
_maxSpanLength = spanLength;
On 2016/06/28 20:36:37, Jacob wrote:
> On 2016/06/28 20:12:31, bmilligan wrote:
> > On 2016/06/28 18:59:11, Jacob wrote:
> > > why is this needed?
> > > Having a public field should have the same externally visible effect.
> > 
> > I don't have access to the debugger.dart file, but only the JsonMLFormatter.
> > Setting devtoolsFormatters[0].maxSpanLength = 6 for example doesn't result
in
> > any change. If I add this setter, though, that command works. Is there a
> > different way to access the public variable without the setter?
> Oh clever. I like this hack. I missed this was inside the JsonMLFormatter
class
> before.
> Just add a comment explaining what you described in your comment so it is
clear
> that this method was added purely for testing purposes.
> Otherwise it would seem to be a bug that you have a instance setters that sets
> the value of a top level field.
> Another option is to make the property name intentionally ugly so it is really
> clear what is going on. E.g.
> 
> void setMaxSpanLengthForTestingOnly(int spanLength) => _maxSpanLength =
> spanLength;

Done.

[Jacob, 2016-06-28 20:47:00]

lgtm

[bmilligan, 2016-06-28 20:49:12]

Description was changed from

==========
maxspanlength setter


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


comments and 10001 case


naming and logic changes


logic updates and variable renaming


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Array formatting customized to look like JS

BUG=
==========

to

==========
maxspanlength setter


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


comments and 10001 case


naming and logic changes


logic updates and variable renaming


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Array formatting customized to look like JS

BUG=
R=jacobr@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/c4e30ddb1d4fe8399ce0dc50c876...
==========

[bmilligan, 2016-06-28 20:49:14]

Committed patchset #2 (id:20001) manually as
c4e30ddb1d4fe8399ce0dc50c8768b6a1e659a15 (presubmit successful).