Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2101233002: X87: [builtins] Introduce proper Float64Tan operator. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Tan operator. port c87168bc8c76cd491f72eb847a962dec2e5ff1fd (r37087) original commit message: Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan operator based on that, similar to what we do for Float64Cos and Float64Sin. Rewrite Math.tan() as TurboFan builtin and use those operators to also inline Math.tan() into optimized TurboFan functions. Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only the %ConstructDouble runtime entry for writing tests. BUG= Committed: https://crrev.com/d944015623582bf3c8f7e25fcb1e400a315311b9 Cr-Commit-Position: refs/heads/master@{#37313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-28 05:54:33 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-28 07:12:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101233002/1
4 years, 5 months ago (2016-06-28 07:14:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 07:38:58 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 07:40:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d944015623582bf3c8f7e25fcb1e400a315311b9
Cr-Commit-Position: refs/heads/master@{#37313}

Powered by Google App Engine
This is Rietveld 408576698