Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2101223002: [liveedit] remove bogus test case. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[liveedit] remove bogus test case. Removing a bad test case because: - The test case makes wrong assumptions about compilation. We now may run bytecode with the interpreter. - The test exposes internal implementation details such as pc offset of JIT code. - The test uses a runtime function specially written to cater to, and used only by this test. Being unmaintained, this runtime function is already returning bogus results, making this test useless. R=jgruber@chromium.org Committed: https://crrev.com/353e1152a59e78f6aaea0f188be65b16be1565bb Cr-Commit-Position: refs/heads/master@{#37312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -174 lines) Patch
M src/debug/liveedit.js View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/debug-liveedit-patch-positions.js View 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
4 years, 5 months ago (2016-06-28 05:49:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101223002/1
4 years, 5 months ago (2016-06-28 06:06:24 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 06:34:04 UTC) #5
jgruber
LGTM modulo blink test failure
4 years, 5 months ago (2016-06-28 07:22:26 UTC) #6
Yang
On 2016/06/28 07:22:26, jgruber wrote: > LGTM modulo blink test failure blink test failure is ...
4 years, 5 months ago (2016-06-28 07:35:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101223002/1
4 years, 5 months ago (2016-06-28 07:35:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 07:37:47 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 07:40:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353e1152a59e78f6aaea0f188be65b16be1565bb
Cr-Commit-Position: refs/heads/master@{#37312}

Powered by Google App Engine
This is Rietveld 408576698