Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Issue 2101183004: VTVDA: Handle more missing IDR situations. (Closed)

Created:
4 years, 5 months ago by sandersd (OOO until July 31)
Modified:
4 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VTVDA: Handle more missing IDR situations. This CL reduces the conditions on dropping frames to just |waiting_for_idr_|. We don't need to consider whether there is a pending config change (this should be a decode error if we are not waiting) or whether |session_| is set (|waiting_for_idr_| covers this). BUG=623892 Committed: https://crrev.com/fcd0ee541d7f3f74171f194dcc86cb1672a33139 Cr-Commit-Position: refs/heads/master@{#402853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
sandersd (OOO until July 31)
4 years, 5 months ago (2016-06-29 01:00:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101183004/1
4 years, 5 months ago (2016-06-29 01:09:00 UTC) #4
DaleCurtis
lgtm
4 years, 5 months ago (2016-06-29 01:12:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 02:25:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101183004/1
4 years, 5 months ago (2016-06-29 17:28:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 17:37:06 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:37:39 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:38:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcd0ee541d7f3f74171f194dcc86cb1672a33139
Cr-Commit-Position: refs/heads/master@{#402853}

Powered by Google App Engine
This is Rietveld 408576698