Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101143005: 0 -> nullptr for UseCounter pointer in CSSParserContext. (Closed)

Created:
4 years, 5 months ago by rune
Modified:
4 years, 5 months ago
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, krit, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, sof, caseq+blink_chromium.org, lushnikov+blink_chromium.org, darktears, Stephen Chennney, gavinp+prerender_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, pfeldman+blink_chromium.org, f(malita), sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

0 -> nullptr for UseCounter pointer in CSSParserContext. I repeatedly find myself looking for constructors taking flags through unsigned before realizing this is actually a pointer. Committed: https://crrev.com/a7bafe5391fe8d2302e39665f2e51aee9819f6f2 Cr-Commit-Position: refs/heads/master@{#403256}

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPageRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101143005/1
4 years, 5 months ago (2016-06-29 12:11:28 UTC) #2
rune
ptal pdr@ for web/ core/ junov@ for modules/canvas2d
4 years, 5 months ago (2016-06-29 12:12:58 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/89008)
4 years, 5 months ago (2016-06-29 12:21:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101143005/20001
4 years, 5 months ago (2016-06-29 12:27:56 UTC) #8
Yoav Weiss
On 2016/06/29 12:27:56, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 5 months ago (2016-06-29 12:36:39 UTC) #9
haraken
LGTM
4 years, 5 months ago (2016-06-29 13:28:51 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 13:44:50 UTC) #12
pdr.
On 2016/06/29 at 13:44:50, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 5 months ago (2016-06-29 17:11:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101143005/20001
4 years, 5 months ago (2016-06-30 18:24:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 19:46:08 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:46:29 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:48:31 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a7bafe5391fe8d2302e39665f2e51aee9819f6f2
Cr-Commit-Position: refs/heads/master@{#403256}

Powered by Google App Engine
This is Rietveld 408576698