Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2101103004:
Add unit tests for revalidating ImageResource (Closed)
|
Created:
4 years, 5 months ago by hiroshige Modified:
4 years, 5 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd unit tests for revalidating ImageResource
BUG=625597, 618623
Committed: https://crrev.com/c01b976a2461e60e1bb83cc85bb085fd9ce08819
Cr-Commit-Position: refs/heads/master@{#403666}
Patch Set 1 #Patch Set 2 : Fix. #
Total comments: 2
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add unit tests for revalidating ImageResource BUG= ========== to ========== Add unit tests for revalidating ImageResource BUG=618623 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/06/29 15:27:30, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. non-owner lgtm Are you willing to launch this CL?
yoav@yoav.ws changed reviewers: + yoav@yoav.ws
Yay for more unittests!! :) https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp (right): https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp:480: EXPECT_EQ(4, client->imageChangedCount()); hmm, why is that 4?
https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp (right): https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp:480: EXPECT_EQ(4, client->imageChangedCount()); On 2016/07/04 08:28:10, Yoav Weiss wrote: > hmm, why is that 4? For each of the first response (jpegImage()) and the revalidating response (jpegImage2()), imageChanged() is called twice: in notifyObservers() in updateImage(false) in ImageResource::appendData(), and in notifyObservers() in updateImage(true) in finish() Therefore imageChanged() is called for 2 + 2 = 4 times at total.
On 2016/07/04 09:02:11, hiroshige wrote: > https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp (right): > > https://codereview.chromium.org/2101103004/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp:480: EXPECT_EQ(4, > client->imageChangedCount()); > On 2016/07/04 08:28:10, Yoav Weiss wrote: > > hmm, why is that 4? > > For each of the first response (jpegImage()) and the revalidating response > (jpegImage2()), imageChanged() is called twice: > in notifyObservers() in updateImage(false) in ImageResource::appendData(), and > in notifyObservers() in updateImage(true) in finish() > > Therefore imageChanged() is called for 2 + 2 = 4 times at total. OK, cool. LGTM!
Description was changed from ========== Add unit tests for revalidating ImageResource BUG=618623 ========== to ========== Add unit tests for revalidating ImageResource BUG=625597, 618623 ==========
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add unit tests for revalidating ImageResource BUG=625597, 618623 ========== to ========== Add unit tests for revalidating ImageResource BUG=625597, 618623 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add unit tests for revalidating ImageResource BUG=625597, 618623 ========== to ========== Add unit tests for revalidating ImageResource BUG=625597, 618623 Committed: https://crrev.com/c01b976a2461e60e1bb83cc85bb085fd9ce08819 Cr-Commit-Position: refs/heads/master@{#403666} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c01b976a2461e60e1bb83cc85bb085fd9ce08819 Cr-Commit-Position: refs/heads/master@{#403666} |
