Subzero: Fix Calling Convention for MIPS O32 abi

src/IceTargetLoweringMIPS32.cpp

Index: src/IceTargetLoweringMIPS32.cpp
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index 0da1d2813935c3f2876e724ca93894a6ad2b6443..982ad391e5fe13b6845233be2f32c2c0080147c9 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -559,6 +559,11 @@ inline void TargetMIPS32::CallingConv::discardNextGPRAndItsAliases(
   Regs->pop_back();
 }
 
+inline void TargetMIPS32::CallingConv::alignGPR(CfgVector<RegNumT> *Regs) {
+  if (Regs->back() == RegMIPS32::Reg_A1 || Regs->back() == RegMIPS32::Reg_A3)
+    discardNextGPRAndItsAliases(Regs);
+}
+
 // GPR are not packed when passing parameters. Thus, a function foo(i32, i64,
 // i32) will have the first argument in a0, the second in a2-a3, and the third
 // on the stack. To model this behavior, whenever we pop a register from Regs,
@@ -603,10 +608,18 @@ bool TargetMIPS32::CallingConv::argInVFP(Type Ty, RegNumT *Reg) {
   // in reg_a3 and a0, a1 are not used.
   Source = &GPRArgs;
   // Discard one GPR reg for f32(4 bytes), two for f64(4 + 4 bytes)
-  discardNextGPRAndItsAliases(Source);
-  if (Ty == IceType_f64)
+  if (Ty == IceType_f64) {
+    // In MIPS o32 abi, when we use GPR argument pairs to store F64 values, pair

[Jim Stichnoth, 2016/06/28 14:00:52]

In this instance, the "GPR" should actually be "FPR", right?

[mohit.bhakkad, 2016/06/29 06:37:43]

No, in MIPS o32 abi, after first two arguments, even if argument is of type
f32/f64, we have to use GPR pair(if available) to store it.

+    // must be aligned at even register. Similarly when we discard GPR registers
+    // when some arguments from starting 16 bytes goes in FPR, we must take care
+    // of alignment. For example if fun args are (f32, f64, f32), for first f32
+    // we discard a0, now for f64 argument, which will go in F14F15, we must
+    // first align GPR vector to even register by discarding a1, then discard
+    // two GPRs a2 and a3. Now last f32 argumnet will go on stack.

[Jim Stichnoth, 2016/06/28 14:00:52]

argument

+    alignGPR(Source);
     discardNextGPRAndItsAliases(Source);
-
+  }
+  discardNextGPRAndItsAliases(Source);
   return true;
 }