Subzero: Fix Calling Convention for MIPS O32 abi

Subzero: Fix Calling Convention for MIPS O32 abi

We should take care of alignment while discarding GPR registers, I have written larger explanation in a comment.

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bbb5fa7e3808221c5580b4d410f8b5c17f095f04

[mohit.bhakkad, 2016-06-28 11:58:49]

Description was changed from

==========
Fix Calling Convention for MIPS O32 abi
==========

to

==========
We should take care of alignment while discarding GPR registers, I have written
larger explanation in a comment.
==========

[mohit.bhakkad, 2016-06-28 11:58:49]

mohit.bhakkad@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
stichnot@chromium.org

[Jim Stichnoth, 2016-06-28 14:00:52]

Also, in the Description field of the CL, please begin with a duplicate of the
title, followed by a blank line, since the Description field is what goes into
the git commit message.  E.g.:

  Subzero: Fix Calling Convention for MIPS O32 abi

  We should take care of alignment ...

(Also, I like to start with "Subzero:" because all the various NaCl sub-project
CLs get mixed into the same codereview site.)

https://codereview.chromium.org/2101093003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2101093003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:612: // In MIPS o32 abi, when we use GPR
argument pairs to store F64 values, pair
In this instance, the "GPR" should actually be "FPR", right?

https://codereview.chromium.org/2101093003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:618: // two GPRs a2 and a3. Now last f32
argumnet will go on stack.
argument

[mohit.bhakkad, 2016-06-29 06:32:33]

Description was changed from

==========
We should take care of alignment while discarding GPR registers, I have written
larger explanation in a comment.
==========

to

==========
Subzero: Fix Calling Convention for MIPS O32 abi

We should take care of alignment while discarding GPR registers, I have written
larger explanation in a comment.
==========

[mohit.bhakkad, 2016-06-29 06:37:43]

https://codereview.chromium.org/2101093003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2101093003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:612: // In MIPS o32 abi, when we use GPR
argument pairs to store F64 values, pair
On 2016/06/28 14:00:52, stichnot wrote:
> In this instance, the "GPR" should actually be "FPR", right?

No, in MIPS o32 abi, after first two arguments, even if argument is of type
f32/f64, we have to use GPR pair(if available) to store it.

[Jim Stichnoth, 2016-06-29 13:50:43]

lgtm

[Jim Stichnoth, 2016-06-29 13:51:12]

Description was changed from

==========
Subzero: Fix Calling Convention for MIPS O32 abi

We should take care of alignment while discarding GPR registers, I have written
larger explanation in a comment.
==========

to

==========
Subzero: Fix Calling Convention for MIPS O32 abi

We should take care of alignment while discarding GPR registers, I have written
larger explanation in a comment.

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-06-29 13:51:14]

Committed patchset #2 (id:20001) manually as
bbb5fa7e3808221c5580b4d410f8b5c17f095f04 (presubmit successful).