third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html - Issue 2101073002: [DevTools] Always report encodedDataLength in Network.ResponseReceived.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

Issue 2101073002: [DevTools] Always report encodedDataLength in Network.ResponseReceived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/netlog_observer.cc ('K') | « content/browser/loader/netlog_observer.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

index df9b57d2a7457c76735f14737250c1471c2fbd58..3841a0ffa1f4c2c5d67c21d629be80db2026756d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

@@ -19,11 +19,11 @@ function test()

InspectorTest.evaluateInPage("loadIFrame()");

var encodedBytesReceived = 0;

- function responseReceived(requestId, time, resourceType, response)

+ function responseReceived(requestId, frameId, loaderId, time, resourceType, response)

mmenke 2016/06/28 13:42:58 Where to these new parameters come from?

dgozman 2016/06/28 14:03:08 Looks like the test was not updated when protocol

{

var request = InspectorTest.networkLog.requestForId(requestId);

if (/resource\.php/.exec(request.url))

- InspectorTest.addResult("Received response.");

+ InspectorTest.addResult("Received response. EncodedDataLength is " + (response.encodedDataLength === -1 ? "unknown" : "known") + ".");

}

function loadingFinished(requestId, finishTime, encodedDataLength)