content/browser/loader/netlog_observer.cc - Issue 2101073002: [DevTools] Always report encodedDataLength in Network.ResponseReceived.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/loader/netlog_observer.cc

Issue 2101073002: [DevTools] Always report encodedDataLength in Network.ResponseReceived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/loader/netlog_observer.h"	5 #include "content/browser/loader/netlog_observer.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/strings/string_util.h"	9 #include "base/strings/string_util.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 177 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
188 ResourceRequestInfoImpl::ForRequest(request);	188 ResourceRequestInfoImpl::ForRequest(request);

189 if (!request_info \|\| !request_info->ShouldReportRawHeaders())	189 if (!request_info \|\| !request_info->ShouldReportRawHeaders())

190 return;	190 return;

191	191

192 uint32_t source_id = request->net_log().source().id;	192 uint32_t source_id = request->net_log().source().id;

193 NetLogObserver* dev_tools_net_log_observer = NetLogObserver::GetInstance();	193 NetLogObserver* dev_tools_net_log_observer = NetLogObserver::GetInstance();

194 if (dev_tools_net_log_observer == NULL)	194 if (dev_tools_net_log_observer == NULL)

195 return;	195 return;

196 response->head.devtools_info =	196 response->head.devtools_info =

197 dev_tools_net_log_observer->GetResourceInfo(source_id);	197 dev_tools_net_log_observer->GetResourceInfo(source_id);

	198 response->head.encoded_data_length = request->GetTotalReceivedBytes();
	dgozman 2016/06/27 23:02:43 This field is only used by DevTools, so it should This field is only used by DevTools, so it should probably go into ResourceDevToolsInfo. But that's a separate follow-up.
198 }	199 }

199	200

200 } // namespace content	201 } // namespace content

OLD	NEW