Fire OnKeyboardBoundsChanging event when Display metrics changes

Fire OnKeyboardBoundsChanging event when Display metrics changes

BUG=623648
TEST=KeyboardControllerTest.DisplayChangeShould

Committed: https://crrev.com/caa3e40dcda4ca73dfa50ec34ad0c11cbbc17990
Cr-Commit-Position: refs/heads/master@{#403364}

[oshima, 2016-06-27 19:15:13]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 19:15:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 20:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 20:35:09]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-06-27 20:42:28]

oshima@chromium.org changed reviewers:
+ bshe@chromium.org

[bshe, 2016-06-28 12:14:17]

https://codereview.chromium.org/2101023002/diff/1/ui/keyboard/keyboard_layout...
File ui/keyboard/keyboard_layout_manager.cc (right):

https://codereview.chromium.org/2101023002/diff/1/ui/keyboard/keyboard_layout...
ui/keyboard/keyboard_layout_manager.cc:23: SetChildBounds(keyboard_,
gfx::Rect(container_bounds.size()));
Would it possible for you to try rotate the screen before show keyboard
animation finishes? I vaguely remember that we have to use SetChildBoundsDirect
here for animation reason, but I can't remember details. It is easier to test if
you change the animation time here:
https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_controller.cc?rcl=0...

Also, I dont remember we change the height (in pixel) of VK at all. If it is
full width mode, do we need to notify clients again?

[oshima, 2016-06-28 14:48:10]

On 2016/06/28 12:14:17, bshe wrote:
>
https://codereview.chromium.org/2101023002/diff/1/ui/keyboard/keyboard_layout...
> File ui/keyboard/keyboard_layout_manager.cc (right):
> 
>
https://codereview.chromium.org/2101023002/diff/1/ui/keyboard/keyboard_layout...
> ui/keyboard/keyboard_layout_manager.cc:23: SetChildBounds(keyboard_,
> gfx::Rect(container_bounds.size()));
> Would it possible for you to try rotate the screen before show keyboard
> animation finishes? I vaguely remember that we have to use
SetChildBoundsDirect
> here for animation reason, but I can't remember details. It is easier to test
if
> you change the animation time here:
>
https://cs.chromium.org/chromium/src/ui/keyboard/keyboard_controller.cc?rcl=0...

Do you remember what was the issue? It looks working fine except that it stops
animation,
which should be expected.

> 
> Also, I dont remember we change the height (in pixel) of VK at all. If it is
> full width mode, do we need to notify clients again?

When display size changes, the VK bounds also changes so we need to notify.
For example, the web contents does not exit "show only input region" mode when
VK side changes due to rotation.

[oshima, 2016-06-29 23:34:44]

ping?

[kevers, 2016-06-30 20:31:09]

kevers@chromium.org changed reviewers:
+ kevers@chromium.org

[kevers, 2016-06-30 20:31:10]

lgtm

[bshe, 2016-06-30 20:40:55]

On 2016/06/30 20:31:10, kevers wrote:
> lgtm

dooh. I though I have lgtmed
No I dont remember specific. Stop animation is what we expect.

[oshima, 2016-06-30 22:37:12]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-06-30 22:37:22]

On 2016/06/30 20:40:55, bshe wrote:
> On 2016/06/30 20:31:10, kevers wrote:
> > lgtm
> 
> dooh. I though I have lgtmed
> No I dont remember specific. Stop animation is what we expect.

np :)

[commit-bot: I haz the power, 2016-06-30 22:37:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:19:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 00:19:33]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 00:21:00]

Description was changed from

==========
Fire OnKeyboardBoundsChanging event when Display metrics changes

BUG=623648
TEST=KeyboardControllerTest.DisplayChangeShould
==========

to

==========
Fire OnKeyboardBoundsChanging event when Display metrics changes

BUG=623648
TEST=KeyboardControllerTest.DisplayChangeShould

Committed: https://crrev.com/caa3e40dcda4ca73dfa50ec34ad0c11cbbc17990
Cr-Commit-Position: refs/heads/master@{#403364}
==========

[commit-bot: I haz the power, 2016-07-01 00:21:01]

Patchset 1 (id:??) landed as
https://crrev.com/caa3e40dcda4ca73dfa50ec34ad0c11cbbc17990
Cr-Commit-Position: refs/heads/master@{#403364}