Issue 2100993002: Switch back to the old go generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2100993002: Switch back to the old go generator. (Closed)

Created:
4 years, 5 months ago by azani

Modified:
4 years, 5 months ago

Reviewers:
kulakowski, viettrungluu

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Switch back to the old go generator. R=kulakowski BUG= #797 Committed: https://chromium.googlesource.com/external/mojo/+/f327fe7962e48e80875df6261c40b4c2296b9f42

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/public/tools/bindings/mojom.gni	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/public/tools/bindings/run_code_generators.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

azani

Committed patchset #1 (id:1) manually as f327fe7962e48e80875df6261c40b4c2296b9f42.

4 years, 5 months ago (2016-06-27 18:46:27 UTC) #5

azani

4 years, 5 months ago (2016-06-27 18:46:59 UTC) #6

Message was sent while issue was closed.

tbr'd since it fixes a currently-breaking build for some people.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages