Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: remoting/client/jni/jni_display_handler.h

Issue 2100943004: [Remoting Android] Make JniClient own JniDisplayHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/jni/jni_client.cc ('k') | remoting/client/jni/jni_display_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/jni_display_handler.h
diff --git a/remoting/client/jni/jni_display_handler.h b/remoting/client/jni/jni_display_handler.h
index 054fe239af7cb3ede444b447b758ed678d258133..de94f7a06ff295a0576c22f00ef32d0b42c753a6 100644
--- a/remoting/client/jni/jni_display_handler.h
+++ b/remoting/client/jni/jni_display_handler.h
@@ -25,12 +25,13 @@ class JniVideoRenderer;
// unless otherwise noted.
class JniDisplayHandler : public DisplayUpdaterFactory {
public:
- JniDisplayHandler(ChromotingJniRuntime* runtime,
- base::android::ScopedJavaGlobalRef<jobject> java_display);
+ explicit JniDisplayHandler(ChromotingJniRuntime* runtime);
// Must be deleted on the display thread.
~JniDisplayHandler() override;
+ base::android::ScopedJavaLocalRef<jobject> GetJavaDisplay();
+
void UpdateCursorShape(const protocol::CursorShapeInfo& cursor_shape);
// DisplayUpdaterFactory overrides (functions can be called on any thread).
@@ -51,10 +52,6 @@ class JniDisplayHandler : public DisplayUpdaterFactory {
static bool RegisterJni(JNIEnv* env);
- // Deletes this object on display thread. Can be called on any thread.
- void Destroy(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& caller);
-
// Schedule redraw. Can be called on any thread.
void ScheduleRedraw(JNIEnv* env,
const base::android::JavaParamRef<jobject>& caller);
« no previous file with comments | « remoting/client/jni/jni_client.cc ('k') | remoting/client/jni/jni_display_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698