Add documentation to List.filled to warn of common mistake.

Add documentation to List.filled to warn of common mistake.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/d28687f1f725b680af31f5f7a8f3a54e5d033147

[floitsch, 2016-06-27 18:27:22]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-06-27 18:45:46]

lgtm

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:92: * All entries in the returned list point to provided
[fill] value. This is
"to the provided"
or even
"to the same provided"


"This is observable" -> "That all items in the list are the same object is
observable ..."

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:101: * If that's not the intended behavior, use
[List.generate] instead:
use [List.generate] instead -> you may use [List.generate] to create a new
object for each position in the created list instead

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:104: * unique[[0].add(499);
[[ -> [


(I recommend trying examples in dartpad, just to be absolutely sure they run).

[floitsch, 2016-06-28 00:49:00]

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:92: * All entries in the returned list point to provided
[fill] value. This is
On 2016/06/27 18:45:46, Lasse Reichstein Nielsen wrote:
> "to the provided"
> or even
> "to the same provided"
> 
> 
> "This is observable" -> "That all items in the list are the same object is
> observable ..."

Done.

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:101: * If that's not the intended behavior, use
[List.generate] instead:
On 2016/06/27 18:45:46, Lasse Reichstein Nielsen wrote:
> use [List.generate] instead -> you may use [List.generate] to create a new
> object for each position in the created list instead
> 

Done.

https://codereview.chromium.org/2100943003/diff/1/sdk/lib/core/list.dart#newc...
sdk/lib/core/list.dart:104: * unique[[0].add(499);
On 2016/06/27 18:45:46, Lasse Reichstein Nielsen wrote:
> [[ -> [
> 
> 
> (I recommend trying examples in dartpad, just to be absolutely sure they run).

I tried in dartpad too, but copied it by hand (because of the "*" in front...).

done.

[floitsch, 2016-06-29 00:30:40]

Description was changed from

==========
Add documentation to List.filled to warn of common mistake.
==========

to

==========
Add documentation to List.filled to warn of common mistake.

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d28687f1f725b680af31f5f7a8f3a54e5d033147
==========

[floitsch, 2016-06-29 00:30:42]

Committed patchset #2 (id:20001) manually as
d28687f1f725b680af31f5f7a8f3a54e5d033147 (presubmit successful).