Add tests for InputDevice/TouchscreenDevice StructTraits.

Add tests for InputDevice/TouchscreenDevice StructTraits.

Add test to ensure serialization/deserialization produces unchanged
InputDevice and TouchScreenDevice objects.

BUG=601981
Committed: https://crrev.com/b9e61b4b1e0c94947c32d6d74741e0a335f8b981
Cr-Commit-Position: refs/heads/master@{#402569}

[kylechar, 2016-06-27 15:10:44]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-06-27 15:17:39]

lgtm

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/DEPS
File ui/events/devices/mojo/DEPS (right):

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/DEPS...
ui/events/devices/mojo/DEPS:4: 
Remove

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
File ui/events/devices/mojo/device_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
ui/events/devices/mojo/device_struct_traits_unittest.cc:41: base::MessageLoop
loop_;  // Needed otherwise DCHECK fails.
Which DCHECK? (I don't think the comment is all that useful. Perhaps something
more like "A MessageLoop is needed for mojo IPC to work."

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
ui/events/devices/mojo/device_struct_traits_unittest.cc:77: input.product_id =
0;
Set some non-zero values here?

[kylechar, 2016-06-27 15:25:59]

Thanks!

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/DEPS
File ui/events/devices/mojo/DEPS (right):

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/DEPS...
ui/events/devices/mojo/DEPS:4: 
On 2016/06/27 15:17:39, sadrul wrote:
> Remove

Done.

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
File ui/events/devices/mojo/device_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
ui/events/devices/mojo/device_struct_traits_unittest.cc:41: base::MessageLoop
loop_;  // Needed otherwise DCHECK fails.
On 2016/06/27 15:17:39, sadrul wrote:
> Which DCHECK? (I don't think the comment is all that useful. Perhaps something
> more like "A MessageLoop is needed for mojo IPC to work."

Done.

https://codereview.chromium.org/2100893002/diff/1/ui/events/devices/mojo/devi...
ui/events/devices/mojo/device_struct_traits_unittest.cc:77: input.product_id =
0;
On 2016/06/27 15:17:39, sadrul wrote:
> Set some non-zero values here?

It seems like these often end up being zero in real data, so checking that case.

[kylechar, 2016-06-27 15:31:59]

kylechar@chromium.org changed reviewers:
+ kenrb@chromium.org, rockot@chromium.org

[kylechar, 2016-06-27 15:31:59]

+kenrb for mojom/struct_traits_unittests.
+rockot for DEPS.

[Ken Rockot(use gerrit already), 2016-06-27 15:34:34]

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/BUILD.gn (right):

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/BUILD.gn:17: mojom("test_service") {
nit: "test_interfaces"?

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/device_traits_test_service.mojom (right):

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/device_traits_test_service.mojom:11: interface
DeviceTraitsTestService {
DeviceTraitsTest is fine (no Service suffixes please)

[kylechar, 2016-06-27 15:44:25]

I've changed the naming around based on your suggestions.

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/BUILD.gn (right):

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/BUILD.gn:17: mojom("test_service") {
On 2016/06/27 15:34:33, Ken Rockot wrote:
> nit: "test_interfaces"?

Done.

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
File ui/events/devices/mojo/device_traits_test_service.mojom (right):

https://codereview.chromium.org/2100893002/diff/20001/ui/events/devices/mojo/...
ui/events/devices/mojo/device_traits_test_service.mojom:11: interface
DeviceTraitsTestService {
On 2016/06/27 15:34:33, Ken Rockot wrote:
> DeviceTraitsTest is fine (no Service suffixes please)

Done.

[Ken Rockot(use gerrit already), 2016-06-27 15:46:02]

lgtm

[kenrb, 2016-06-27 15:47:20]

lgtm

[kylechar, 2016-06-27 15:48:00]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-27 15:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2100893002/#ps40001
(title: "Fix naming.")

[commit-bot: I haz the power, 2016-06-27 15:48:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 17:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:43:57]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kylechar, 2016-06-28 15:44:19]

Patchset #4 (id:60001) has been deleted

[kylechar, 2016-06-28 18:49:31]

Patchset #4 (id:80001) has been deleted

[kylechar, 2016-06-28 18:49:37]

Patchset #5 (id:120001) has been deleted

[kylechar, 2016-06-28 18:49:42]

Patchset #4 (id:100001) has been deleted

[kylechar, 2016-06-28 18:51:18]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-28 18:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
rockot@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2100893002/#ps140001
(title: "Fix win.")

[commit-bot: I haz the power, 2016-06-28 18:52:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:16:02]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-06-28 22:19:56]

Description was changed from

==========
Add tests for InputDevice/TouchscreenDevice StructTraits.

Add test to ensure serialization/deserialization produces unchanged
InputDevice and TouchScreenDevice objects.

BUG=601981
==========

to

==========
Add tests for InputDevice/TouchscreenDevice StructTraits.

Add test to ensure serialization/deserialization produces unchanged
InputDevice and TouchScreenDevice objects.

BUG=601981

Committed: https://crrev.com/b9e61b4b1e0c94947c32d6d74741e0a335f8b981
Cr-Commit-Position: refs/heads/master@{#402569}
==========

[commit-bot: I haz the power, 2016-06-28 22:19:59]

Patchset 4 (id:??) landed as
https://crrev.com/b9e61b4b1e0c94947c32d6d74741e0a335f8b981
Cr-Commit-Position: refs/heads/master@{#402569}