Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/code-stubs.h

Issue 2100883003: [Code Stubs] Convert FastNewClosureStub to a TurboFanCodeStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix ia32 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 85b0883db849033869eae4c5df248d9f907d7c83..a63889992c41da329cdd4e2259df10fceb8dd06f 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -63,7 +63,6 @@ namespace internal {
V(FastCloneRegExp) \
V(FastCloneShallowArray) \
V(FastFunctionBind) \
- V(FastNewClosure) \
V(FastNewContext) \
V(FastNewObject) \
V(FastNewRestParameter) \
@@ -118,6 +117,7 @@ namespace internal {
V(InternalArraySingleArgumentConstructor) \
V(Dec) \
V(FastCloneShallowObject) \
+ V(FastNewClosure) \
V(InstanceOf) \
V(LessThan) \
V(LessThanOrEqual) \
@@ -1034,32 +1034,16 @@ class TypeofStub final : public HydrogenCodeStub {
DEFINE_HYDROGEN_CODE_STUB(Typeof, HydrogenCodeStub);
};
-
-class FastNewClosureStub : public HydrogenCodeStub {
+class FastNewClosureStub : public TurboFanCodeStub {
public:
- FastNewClosureStub(Isolate* isolate, LanguageMode language_mode,
- FunctionKind kind)
- : HydrogenCodeStub(isolate) {
- DCHECK(IsValidFunctionKind(kind));
- set_sub_minor_key(LanguageModeBits::encode(language_mode) |
- FunctionKindBits::encode(kind));
- }
-
- LanguageMode language_mode() const {
- return LanguageModeBits::decode(sub_minor_key());
- }
-
- FunctionKind kind() const {
- return FunctionKindBits::decode(sub_minor_key());
- }
+ explicit FastNewClosureStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
- private:
- STATIC_ASSERT(LANGUAGE_END == 3);
- class LanguageModeBits : public BitField<LanguageMode, 0, 2> {};
- class FunctionKindBits : public BitField<FunctionKind, 2, 9> {};
+ static compiler::Node* Generate(CodeStubAssembler* assembler,
+ compiler::Node* shared_info,
+ compiler::Node* context);
DEFINE_CALL_INTERFACE_DESCRIPTOR(FastNewClosure);
- DEFINE_HYDROGEN_CODE_STUB(FastNewClosure, HydrogenCodeStub);
+ DEFINE_TURBOFAN_CODE_STUB(FastNewClosure, TurboFanCodeStub);
};
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698