Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100883002: DevTools: merge browser_protocol.json files from content and core/inspector. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: merge browser_protocol.json files from content and core/inspector. BUG=618148 NOPRESUBMIT=true Committed: https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8 Cr-Commit-Position: refs/heads/master@{#404070}

Patch Set 1 #

Total comments: 1

Patch Set 2 : gn fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -115 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol_constants.gyp View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol_constants_generator.py View 4 chunks +2 lines, -10 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/devtools/browser_protocol.json View 1 chunk +0 lines, -81 lines 0 comments Download
M content/browser/devtools/devtools.gyp View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 4 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +78 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/PRESUBMIT.py View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
pfeldman
4 years, 5 months ago (2016-06-27 14:06:53 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2100883002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2100883002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#newcode4286 third_party/WebKit/Source/core/inspector/browser_protocol.json:4286: "description": "The SystemInfo domain defines methods and events ...
4 years, 5 months ago (2016-06-27 18:27:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100883002/1
4 years, 5 months ago (2016-06-28 16:18:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/208509)
4 years, 5 months ago (2016-06-28 16:28:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100883002/1
4 years, 5 months ago (2016-07-07 00:39:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/213245)
4 years, 5 months ago (2016-07-07 00:48:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100883002/20001
4 years, 5 months ago (2016-07-07 02:24:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/213307)
4 years, 5 months ago (2016-07-07 02:34:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100883002/20001
4 years, 5 months ago (2016-07-07 03:30:22 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 04:03:04 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 04:03:10 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 04:04:35 UTC) #24
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8
Cr-Commit-Position: refs/heads/master@{#404070}

Powered by Google App Engine
This is Rietveld 408576698