Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2100863003: Disable QUIC v29 and earlier. Protected by FLAGS_quic_disable_pre_30. (Closed)

Created:
4 years, 5 months ago by Jana
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@home
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable QUIC v29 and earlier. Protected by FLAGS_quic_disable_pre_30. Merge internal change: 125080101 R=rch@chromium.org BUG= Committed: https://crrev.com/3090e576a1b366b4cc8faf585d5171e86d46c2aa Cr-Commit-Position: refs/heads/master@{#402327}

Patch Set 1 #

Patch Set 2 : Fixing compile error on android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +9 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 5 chunks +16 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Jana
4 years, 5 months ago (2016-06-27 20:46:19 UTC) #1
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-06-27 20:48:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100863003/1
4 years, 5 months ago (2016-06-27 20:48:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/88038) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 21:13:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100863003/20001
4 years, 5 months ago (2016-06-27 21:19:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 23:09:32 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:12:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3090e576a1b366b4cc8faf585d5171e86d46c2aa
Cr-Commit-Position: refs/heads/master@{#402327}

Powered by Google App Engine
This is Rietveld 408576698