Issue 2100843003: [Mac/GN] Add missing -Wglobal-constructors to //third_party/WebKit.

Issue 2100843003: [Mac/GN] Add missing -Wglobal-constructors to //third_party/WebKit. (Closed)

Created:
4 years, 5 months ago by Robert Sesek

Modified:
4 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, blink-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Mac/GN] Add missing -Wglobal-constructors to //third_party/WebKit. BUG=622889 R=thakis@chromium.org Committed: https://crrev.com/8bce28f344412001f474d69f7595233d9310af6b Cr-Commit-Position: refs/heads/master@{#402382}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)			Patch
M	third_party/WebKit/Source/core/BUILD.gn	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100843003/1

4 years, 5 months ago (2016-06-28 00:57:54 UTC) #4

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 02:35:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8bce28f344412001f474d69f7595233d9310af6b
Cr-Commit-Position: refs/heads/master@{#402382}