Add a whole-app-list unit test.

Add a whole-app-list unit test.

This establishes a test harness for doing tests that touch on multiple
parts of the app launcher UI, or that need coverage for the various app
launcher configurations: Ash or Desktop; regular or experimental
"landscape" mode.

It currently just tests displaying and closing the app launcher in its
default state with a flat (no folders), 2- or 3-page model.

BUG=169114
TEST=Added unit tests AppListViewTest{Aura,Desktop}.*

Previously committed: http://crrev.com/260762 http://crrev.com/260803

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270708

[calamity, 2014-03-31 05:37:33]

lgtm.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:37: class AppListViewTestWithContext
{
AppListViewTestWithContext sounds like this is the test base class.
AppListViewTestContext maybe? Fits well with test_context_ below.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:77: virtual void ViewClosing()
OVERRIDE { parent_->NativeWidgetClosing(); }
// Overridden from app_list::test::AppListTestViewDelegate:

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:86: :
is_landscape_(strstr(TestName(), "Landscape")) {
base::EndsWith()?

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:121: view_->ShowWhenReady();
Hmm. ShowWhenReady() is only used by ChromeOS. Will that cause any issues?

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:145: /* Note: |view_| will be have
been deleted here, and set to NULL. */
Is this worth EXPECTing then?

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:172: AppListViewTestDesktop() {}
Destructor (and above)?

[tapted, 2014-04-01 00:09:09]

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:37: class AppListViewTestWithContext
{
On 2014/03/31 05:37:33, calamity wrote:
> AppListViewTestWithContext sounds like this is the test base class.
> AppListViewTestContext maybe? Fits well with test_context_ below.

Done.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:77: virtual void ViewClosing()
OVERRIDE { parent_->NativeWidgetClosing(); }
On 2014/03/31 05:37:33, calamity wrote:
> // Overridden from app_list::test::AppListTestViewDelegate:

Done.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:86: :
is_landscape_(strstr(TestName(), "Landscape")) {
On 2014/03/31 05:37:33, calamity wrote:
> base::EndsWith()?

Done.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:121: view_->ShowWhenReady();
On 2014/03/31 05:37:33, calamity wrote:
> Hmm. ShowWhenReady() is only used by ChromeOS. Will that cause any issues?

Ah, good point. Changed it to GetWidget()->Show() -- it's nice and symmetric
with the Close() at the end of the function now. Also gives a nice opportunity
to test ShowWhenReady separately later on.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:145: /* Note: |view_| will be have
been deleted here, and set to NULL. */
On 2014/03/31 05:37:33, calamity wrote:
> Is this worth EXPECTing then?

Done. Also fixed my grammar fail.

https://codereview.chromium.org/210083009/diff/180001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:172: AppListViewTestDesktop() {}
On 2014/03/31 05:37:33, calamity wrote:
> Destructor (and above)?

Done.

[tapted, 2014-04-01 00:09:15]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-04-01 00:11:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/210083009/220001

[commit-bot: I haz the power, 2014-04-01 02:56:28]

Change committed as 260762

[tkent, 2014-04-01 03:36:07]

A revert of this CL has been created in
https://codereview.chromium.org/220323005/ by tkent@chromium.org.

The reason for reverting is: Broke Linux build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/29...

../../ui/app_list/views/app_list_view_unittest.cc:9:39: fatal error:
base/strings/string_util.h.: No such file or directory
.

[tapted, 2014-04-01 05:20:47]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-04-01 05:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/210083009/240001

[commit-bot: I haz the power, 2014-04-01 08:57:31]

Change committed as 260803

[Mike West, 2014-04-01 11:07:48]

A revert of this CL has been created in
https://codereview.chromium.org/220873002/ by mkwst@chromium.org.

The reason for reverting is: This patch broke 'sizes' by adding a static
initializer.
Seehttp://build.chromium.org/p/chromium/builders/Linux/builds/48686/steps/sizes/logs/stdio
for the detailed dump..

[tapted, 2014-05-13 04:56:00]

Hi Chris, PTAL.

Changes since Patchset 10:
 - rebase for changes like ShouldCenterWindow() / "experimental" ->
switches::kEnableCenteredAppList
 - Use TEST_P and INSTANTIATE_TEST_CASE_P to iterate over centred/not-centred
 - removes the global variable to avoid static initializers (the refactoring
around AppListService means this is now fairly unobtrusive - see also
http://crrev.com/235692). Making it per-view/service rather than global also
means that the (probably theoretical anyway) metro-mode app list won't
accidentally record metrics for something started in desktop mode.

[calamity, 2014-05-15 04:53:24]

lgtm.

[tapted, 2014-05-15 05:03:07]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-05-15 05:05:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/210083009/380001

[commit-bot: I haz the power, 2014-05-15 07:17:48]

Change committed as 270615

[tapted, 2014-05-15 07:29:49]

A revert of this CL has been created in
https://codereview.chromium.org/290433003/ by tapted@chromium.org.

The reason for reverting is: Despite all the green, and earlier full compile on
the same bot, now fails compile on Linux Builder.

../../ui/app_list/views/app_list_view_unittest.cc:239:8:error: 'host' was not
declared in this scope

link:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/31637.

[tapted, 2014-05-15 08:18:38]

This had a fight/race with http://crrev.com/270606 in the CQ.. let's try again..

https://codereview.chromium.org/210083009/diff/380001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/210083009/diff/380001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:239: host()->Show();
removed this. Having it gets a bit more coverage of drawing code, but that's
tested elsewhere and slows the test down. Also, it's now gone from the interface
and the way to get it back needs a DEPS change.

[tapted, 2014-05-15 08:19:16]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-05-15 08:22:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/210083009/400001

[commit-bot: I haz the power, 2014-05-15 10:17:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-15 17:13:19]

Change committed as 270708