Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100813002: Handle rti for closures. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle rti for closures. Use ResolvedAst to retrieve ClosureClassMap data for runtime type information. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/717333c801658b267575ea58ae98dfafd45cc005

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M pkg/compiler/lib/src/dart2js.dart View 1 1 chunk +2 lines, -2 lines 2 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-06-27 12:16:51 UTC) #2
Johnni Winther
4 years, 5 months ago (2016-06-27 12:16:53 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2100813002/diff/20001/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/2100813002/diff/20001/pkg/compiler/lib/src/dart2js.dart#newcode476 pkg/compiler/lib/src/dart2js.dart:476: "resolution output. Use the '--out' option to specify ...
4 years, 5 months ago (2016-06-27 17:07:37 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as 717333c801658b267575ea58ae98dfafd45cc005 (presubmit successful).
4 years, 5 months ago (2016-06-28 07:37:00 UTC) #6
Johnni Winther
4 years, 5 months ago (2016-06-28 07:37:04 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2100813002/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2100813002/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart2js.dart:476: "resolution output. Use the '--out'
option to specify another resolution "
On 2016/06/27 17:07:36, Harry Terkelsen wrote:
> nit: long line

dartfmt!

Powered by Google App Engine
This is Rietveld 408576698