Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2100803004:
Options: Fix android app settings visibility. (Closed)
|
Created:
4 years, 5 months ago by Ben Kwa Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOptions: Fix android app settings visibility.
Only fiddle with the visibility of the setting when an actual change is
committed in preferences. This avoids problems arising from linking it
to intermediate UI state.
BUG=623624
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/bbdaaa80891607e7f1d3b5cca63636541d716b00
Cr-Commit-Position: refs/heads/master@{#403080}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 ========== to ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
kenobi@chromium.org changed reviewers: + dbeam@chromium.org
lgtm
The CQ bit was checked by kenobi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kenobi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Options: Fix android app settings visibility. Only fiddle with the visibility of the setting when an actual change is committed in preferences. This avoids problems arising from linking it to intermediate UI state. BUG=623624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bbdaaa80891607e7f1d3b5cca63636541d716b00 Cr-Commit-Position: refs/heads/master@{#403080} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bbdaaa80891607e7f1d3b5cca63636541d716b00 Cr-Commit-Position: refs/heads/master@{#403080} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
