Chromium Code Reviews Chromium Code Reviews
Issue 21008004:
Changes argument passing to use options objects (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 """Defines named tuples of contains options relevant to each test type.""" | |
|
frankf
2013/07/31 00:14:00
Just move these to test_runner
gkanwar1
2013/07/31 18:07:06
The problem with that is that we need to import th
| |
| 6 | |
| 7 import collections | |
| 8 | |
| 9 | |
| 10 COMMON_OPTIONS = [ | |
| 11 'build_type', | |
| 12 'tool', | |
| 13 'cleanup_test_files', | |
| 14 'push_deps', | |
| 15 ] | |
| 16 | |
| 17 COMMON_JAVA_OPTIONS = [ | |
| 18 'annotations', | |
| 19 'exclude_annotations', | |
| 20 'test_filter', | |
| 21 'test_data', | |
| 22 'save_perf_json', | |
| 23 'screenshot_failures', | |
| 24 'disable_assertions', | |
| 25 ] | |
| 26 | |
| 27 UIAUTOMATOR_OPTIONS = [ | |
| 28 'uiautomator_jar', | |
| 29 'uiautomator_info_jar', | |
| 30 'package_name', | |
| 31 ] | |
| 32 | |
| 33 INSTRUMENTATION_OPTIONS = [ | |
| 34 'wait_for_debugger', | |
| 35 'install_apk', | |
| 36 'test_apk', | |
| 37 'test_apk_path', | |
| 38 'test_apk_jar_path', | |
| 39 ] | |
| 40 | |
| 41 GTEST_FRAMEWORK_OPTIONS = [ | |
| 42 'gtest_filter', | |
| 43 'test_arguments', | |
| 44 'exe', | |
| 45 'timeout', | |
| 46 'suite_name', | |
| 47 ] | |
| 48 | |
| 49 UIAutomatorOptions = collections.namedtuple('UIAutomatorOptions', | |
| 50 COMMON_OPTIONS + | |
| 51 COMMON_JAVA_OPTIONS + | |
| 52 UIAUTOMATOR_OPTIONS) | |
| 53 | |
| 54 InstrumentationOptions = collections.namedtuple('InstrumentationOptions', | |
| 55 COMMON_OPTIONS + | |
| 56 COMMON_JAVA_OPTIONS + | |
| 57 INSTRUMENTATION_OPTIONS) | |
| 58 | |
| 59 GTestOptions = collections.namedtuple('GTestOptions', | |
| 60 COMMON_OPTIONS + | |
| 61 GTEST_FRAMEWORK_OPTIONS) | |
| OLD | NEW |
