Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: src/interpreter/bytecodes.h

Issue 2100793003: [interpreter] Streamline bytecode array writing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-traits.h ('k') | src/interpreter/bytecodes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index 63a69f1699af136f2b666f3f3695d830d7dd51a8..f3b872f377e5cbb5f85ce392b228445fb1a56917 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -438,6 +438,9 @@ class Register final {
class Bytecodes {
public:
+ // The maximum number of operands a bytecode may have.
+ static const int kMaxOperands = 4;
+
// Returns string representation of |bytecode|.
static const char* ToString(Bytecode bytecode);
@@ -525,19 +528,11 @@ class Bytecodes {
static OperandSize GetOperandSize(Bytecode bytecode, int i,
OperandScale operand_scale);
- // Returns a pointer to an array of the operand sizes for |bytecode|.
- static const OperandSize* GetOperandSizes(Bytecode bytecode,
- OperandScale operand_scale);
-
// Returns the offset of the i-th operand of |bytecode| relative to the start
// of the bytecode.
static int GetOperandOffset(Bytecode bytecode, int i,
OperandScale operand_scale);
- // Returns a zero-based bitmap of the register operand positions of
- // |bytecode|.
- static int GetRegisterOperandBitmap(Bytecode bytecode);
-
// Returns a debug break bytecode to replace |bytecode|.
static Bytecode GetDebugBreak(Bytecode bytecode);
« no previous file with comments | « src/interpreter/bytecode-traits.h ('k') | src/interpreter/bytecodes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698