Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: src/interpreter/bytecode-array-writer.h

Issue 2100793003: [interpreter] Streamline bytecode array writing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Incorporate comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-writer.h
diff --git a/src/interpreter/bytecode-array-writer.h b/src/interpreter/bytecode-array-writer.h
index 76d881ed58be4835df8372ec9e516278875d22dc..251edcd96e439a967e70a5d82ca90a70eaa71fc8 100644
--- a/src/interpreter/bytecode-array-writer.h
+++ b/src/interpreter/bytecode-array-writer.h
@@ -34,6 +34,13 @@ class BytecodeArrayWriter final : public BytecodePipelineStage {
Handle<FixedArray> handler_table) override;
private:
+ // Maximum sized packed bytecode is comprised of a prefix bytecode,
+ // plus the actual bytecode, plus the maximum number of operands times
+ // the maximum operand size.
+ static const size_t kMaxSizeOfPackedBytecode =
+ 2 * sizeof(Bytecode) +
+ Bytecodes::kMaxOperands * sizeof(static_cast<size_t>(OperandSize::kLast));
rmcilroy 2016/06/28 09:07:26 I don't think you want the sizeof here any longer,
+
// Constants that act as placeholders for jump operands to be
// patched. These have operand sizes that match the sizes of
// reserved constant pool entries.
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698