Chromium Code Reviews

Unified Diff: src/interpreter/bytecodes.h

Issue 2100793003: [interpreter] Streamline bytecode array writing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index 0e0137fcab012984c0485c2470fdcc413c6601c5..676e3c90667501a696fd823d392351538f8c6ba0 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -440,6 +440,9 @@ class Register final {
class Bytecodes {
public:
+ // The maximum number of operands a bytecode may have.
+ static const int kMaxOperands = 4;
+
// Returns string representation of |bytecode|.
static const char* ToString(Bytecode bytecode);
@@ -527,19 +530,11 @@ class Bytecodes {
static OperandSize GetOperandSize(Bytecode bytecode, int i,
OperandScale operand_scale);
- // Returns a pointer to an array of the operand sizes for |bytecode|.
- static const OperandSize* GetOperandSizes(Bytecode bytecode,
- OperandScale operand_scale);
-
// Returns the offset of the i-th operand of |bytecode| relative to the start
// of the bytecode.
static int GetOperandOffset(Bytecode bytecode, int i,
OperandScale operand_scale);
- // Returns a zero-based bitmap of the register operand positions of
- // |bytecode|.
- static int GetRegisterOperandBitmap(Bytecode bytecode);
-
// Returns a debug break bytecode to replace |bytecode|.
static Bytecode GetDebugBreak(Bytecode bytecode);

Powered by Google App Engine