Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: components/pdf/renderer/pepper_pdf_host.cc

Issue 2100753003: Enable PDF accessibility when RenderFrame's accessibility mode changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Work around cross-platform whitespace difference in print preview test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.h ('k') | content/public/renderer/pepper_plugin_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pdf/renderer/pepper_pdf_host.cc
diff --git a/components/pdf/renderer/pepper_pdf_host.cc b/components/pdf/renderer/pepper_pdf_host.cc
index ab9418b33db14ef60cd5f21fd768156e506731a6..d8a05402fa51359f60194885e544a9c77fbd808c 100644
--- a/components/pdf/renderer/pepper_pdf_host.cc
+++ b/components/pdf/renderer/pepper_pdf_host.cc
@@ -197,11 +197,9 @@ int32_t PepperPDFHost::OnHostMsgSetLinkUnderCursor(
int32_t PepperPDFHost::OnHostMsgSetAccessibilityViewportInfo(
ppapi::host::HostMessageContext* context,
const PP_PrivateAccessibilityViewportInfo& viewport_info) {
- content::PepperPluginInstance* instance =
- host_->GetPluginInstance(pp_instance());
- if (!instance)
+ if (!host_->GetPluginInstance(pp_instance()))
return PP_ERROR_FAILED;
- CreatePdfAccessibilityTreeIfNeeded(instance);
+ CreatePdfAccessibilityTreeIfNeeded();
pdf_accessibility_tree_->SetAccessibilityViewportInfo(viewport_info);
return PP_OK;
}
@@ -209,11 +207,9 @@ int32_t PepperPDFHost::OnHostMsgSetAccessibilityViewportInfo(
int32_t PepperPDFHost::OnHostMsgSetAccessibilityDocInfo(
ppapi::host::HostMessageContext* context,
const PP_PrivateAccessibilityDocInfo& doc_info) {
- content::PepperPluginInstance* instance =
- host_->GetPluginInstance(pp_instance());
- if (!instance)
+ if (!host_->GetPluginInstance(pp_instance()))
return PP_ERROR_FAILED;
- CreatePdfAccessibilityTreeIfNeeded(instance);
+ CreatePdfAccessibilityTreeIfNeeded();
pdf_accessibility_tree_->SetAccessibilityDocInfo(doc_info);
return PP_OK;
}
@@ -223,21 +219,18 @@ int32_t PepperPDFHost::OnHostMsgSetAccessibilityPageInfo(
const PP_PrivateAccessibilityPageInfo& page_info,
const std::vector<PP_PrivateAccessibilityTextRunInfo>& text_run_info,
const std::vector<PP_PrivateAccessibilityCharInfo>& chars) {
- content::PepperPluginInstance* instance =
- host_->GetPluginInstance(pp_instance());
- if (!instance)
+ if (!host_->GetPluginInstance(pp_instance()))
return PP_ERROR_FAILED;
- CreatePdfAccessibilityTreeIfNeeded(instance);
+ CreatePdfAccessibilityTreeIfNeeded();
pdf_accessibility_tree_->SetAccessibilityPageInfo(
page_info, text_run_info, chars);
return PP_OK;
}
-void PepperPDFHost::CreatePdfAccessibilityTreeIfNeeded(
- content::PepperPluginInstance* instance) {
+void PepperPDFHost::CreatePdfAccessibilityTreeIfNeeded() {
if (!pdf_accessibility_tree_) {
- pdf_accessibility_tree_.reset(
- new PdfAccessibilityTree(instance->GetRenderView()));
+ pdf_accessibility_tree_.reset(new PdfAccessibilityTree(
+ host_, pp_instance()));
}
}
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.h ('k') | content/public/renderer/pepper_plugin_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698