Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2100733002: Revert of [Chromecast] Use perceptually linear scaling for stream volumes (Closed)

Created:
4 years, 5 months ago by kmackay
Modified:
4 years, 5 months ago
Reviewers:
igorc, halliwell, jyw, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Use perceptually linear scaling for stream volumes (patchset #2 id:20001 of https://codereview.chromium.org/2073223003/ ) Reason for revert: I think we should actually leave the per-stream volume multiplier as linear, and leave it up to whatever sets that multiplier to map correctly from user input to the desired volume curve. Otherwise, we tie the mixer implementation to a specific volume curve, which is looking less and less plausible (particularly since it is used with OEM devices that have an unknown volume curve). Original issue's description: > [Chromecast] Use perceptually linear scaling for stream volumes > > SetVolumeMultiplier(0.5) should give audio that sounds half as loud as > SetVolumeMultiplier(1.0). > > BUG=internal b/29253848 > TEST=manual > > Committed: https://crrev.com/42e51772feb06a971921e4cfcd89ba7661cdf22a > Cr-Commit-Position: refs/heads/master@{#401149} TBR=igorc@chromium.org,alokp@chromium.org,halliwell@chromium.org,jyw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=internal b/29253848 Committed: https://crrev.com/b47a42ee9c9f655a7b83cadb3c2f86954af8f5c5 Cr-Commit-Position: refs/heads/master@{#402591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
kmackay
Created Revert of [Chromecast] Use perceptually linear scaling for stream volumes
4 years, 5 months ago (2016-06-27 03:24:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100733002/1
4 years, 5 months ago (2016-06-27 03:25:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-27 03:25:02 UTC) #5
kmackay
Note that other output implementations (eg the ALSA AudioOutputStream implementation) use the given volume as ...
4 years, 5 months ago (2016-06-27 03:25:53 UTC) #6
jyw
On 2016/06/27 03:25:53, kmackay wrote: > Note that other output implementations (eg the ALSA AudioOutputStream ...
4 years, 5 months ago (2016-06-28 21:22:37 UTC) #7
halliwell
On 2016/06/28 21:22:37, jyw wrote: > On 2016/06/27 03:25:53, kmackay wrote: > > Note that ...
4 years, 5 months ago (2016-06-28 21:30:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100733002/1
4 years, 5 months ago (2016-06-28 21:57:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 23:26:42 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:28:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b47a42ee9c9f655a7b83cadb3c2f86954af8f5c5
Cr-Commit-Position: refs/heads/master@{#402591}

Powered by Google App Engine
This is Rietveld 408576698