Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2100723002: Make body background black to mitigate flash on hitting full screen for gallery. (Closed)

Created:
4 years, 5 months ago by oka
Modified:
4 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make body background black to mitigate flash on hitting full screen for gallery. BUG=620574 TEST=none Committed: https://crrev.com/56f5f878bfdfbdf30036b3d0ae5d03b42ff89048 Cr-Commit-Position: refs/heads/master@{#402109}

Patch Set 1 #

Patch Set 2 : sort #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
oka
PTAL
4 years, 5 months ago (2016-06-27 02:36:08 UTC) #3
oka
sort
4 years, 5 months ago (2016-06-27 02:37:32 UTC) #4
fukino
lgtm with a nit. https://codereview.chromium.org/2100723002/diff/20001/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2100723002/diff/20001/ui/file_manager/gallery/css/gallery.css#newcode7 ui/file_manager/gallery/css/gallery.css:7: background: black; nit: background-color is ...
4 years, 5 months ago (2016-06-27 03:13:26 UTC) #5
oka
nit
4 years, 5 months ago (2016-06-27 03:14:50 UTC) #6
oka
https://codereview.chromium.org/2100723002/diff/20001/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2100723002/diff/20001/ui/file_manager/gallery/css/gallery.css#newcode7 ui/file_manager/gallery/css/gallery.css:7: background: black; On 2016/06/27 03:13:26, fukino wrote: > nit: ...
4 years, 5 months ago (2016-06-27 03:44:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100723002/40001
4 years, 5 months ago (2016-06-27 03:44:31 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 04:18:16 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 04:20:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56f5f878bfdfbdf30036b3d0ae5d03b42ff89048
Cr-Commit-Position: refs/heads/master@{#402109}

Powered by Google App Engine
This is Rietveld 408576698